From: Nelson Chu <nelson@rivosinc.com>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
jeffreyalaw@gmail.com, i@maskray.me,
prabhakar.mahadev-lad.rj@bp.renesas.com,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
binutils@sourceware.org, Chris.Paterson2@renesas.com
Subject: Re: [RFC PATCH] ld/emulparams: elf32lriscv-defs: Add support tune the text segment start address
Date: Thu, 22 Dec 2022 10:12:19 +0800 [thread overview]
Message-ID: <CAPpQWtC6KYHqk0On5d6QZBHQpjWECWxaGQqtjTHA-FJYZ-=XBQ@mail.gmail.com> (raw)
In-Reply-To: <CA+V-a8tHo-a7hPYY9+8O1VhFRQp4BaOwDUAqNT1VX+WJnjw0Kw@mail.gmail.com>
On Thu, Dec 22, 2022 at 4:15 AM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
>
>> I think it should be similar to what nds32 did in the
>> ld/emulparams/nds32elf_linux.sh, but I'm not really sure how it works.
>> When should the DEFAULT_TEXT_START_ADDR be defined? Maybe when
>> configure or make, not sure about that. But at least I only see the
>> changes in nds32, all of the other targets won't do that, so this must
>> be a handy little trick, but there are always other ways to do the
>>
>DEFAULT_TEXT_START_ADDR needs to be exported in the shell before doing
>configure && make.. For example for testing I bbappended the binutils
>yocto recipe and exported the variable in do_configure() so that it
>picks up the new offset.
Thanks, that pretty clear to explain how this works.
> > same things - for example, what maskray said should be the general way
> > to do. I don't have any opinion on this change, if it won't break the
> > general build, then probably acceptable. Just that it seems need to
> > introduce the DEFAULT_TEXT_START_ADDR or whatever configure options,
> > so this isn't only be the riscv gnu ld's issue, this will also be the
> > issue of lld, so if the maintainers of lld already have some
> > suggestions, then it will definitely worth to referring to.
> >
> Is there a mailing list for lld so that we could include them in this
> mail thread (I couldn't find one)?
Not really sure which mailing list is the right place to discuss this
for llvm, I only know that they have a patch review system -
Phabricator. But anyway, Maskray (Fangrui) is the lld maintainer, so
he is already here ;)
Thanks
Nelson
next prev parent reply other threads:[~2022-12-22 2:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 21:43 Lad Prabhakar
2022-12-17 9:19 ` Andrew Waterman
2022-12-18 6:24 ` Fangrui Song
2022-12-18 22:44 ` Lad, Prabhakar
2022-12-18 23:09 ` Fangrui Song
2022-12-19 9:02 ` Lad, Prabhakar
2022-12-19 5:00 ` Jeff Law
2022-12-19 9:11 ` Lad, Prabhakar
2022-12-19 21:33 ` Palmer Dabbelt
2022-12-21 13:24 ` Nelson Chu
2022-12-21 20:15 ` Lad, Prabhakar
2022-12-22 2:12 ` Nelson Chu [this message]
2022-12-21 20:06 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPpQWtC6KYHqk0On5d6QZBHQpjWECWxaGQqtjTHA-FJYZ-=XBQ@mail.gmail.com' \
--to=nelson@rivosinc.com \
--cc=Chris.Paterson2@renesas.com \
--cc=andrew@sifive.com \
--cc=binutils@sourceware.org \
--cc=i@maskray.me \
--cc=jeffreyalaw@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=palmer@dabbelt.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).