public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@bitrange.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Re: .macro behavior
Date: Wed, 09 Feb 2005 15:03:00 -0000	[thread overview]
Message-ID: <Pine.BSF.4.58.0502090518430.2582@dair.pair.com> (raw)
In-Reply-To: <s209e1f7.099@emea1-mh.id2.novell.com>

On Wed, 9 Feb 2005, Jan Beulich wrote:
> >I don't see what's wrong with that.  I'd say it actually
> >simplifies macro definitions and usage.  The macro parameter
> >name is used only in a macro definition, as a placeholder. It's
> >no big limitation to make it alphanumeric_ only.  Otherwise, the
> >macro writer that wants to cater to multiple GAS ports (say, in
> >a package similar to glibc) would have to avoid making the
> >parameter name followed by any non-space character at all, in
> >case some port has that character as part of an identifier.
>
> The change doesn't prevent anyone from continuing to only use
> alphanumeric characters for macro parameter names. And such a name can
> validly only be followed by a comma or equal sign (perhaps whitespace,
> but no other punctuation),

You are referring to the ".macro ..." line, right? You don't
really mean within the macro, where the parameter name is *used*
right?

*Within* a macro definition, it can be followed by e.g. a ":",
and the sematics is now changed.

If you're actually making an (artificial) restriction on a macro
parameter name use within a macro definition above, then that
should be documented.

> so allowing more characters for use in
> parameter names can't break anything (at least no properly written
> code), unless a port allows '=' in symbol names (those, the existence of
> which I question, would have to separate parameter name and = by
> whitespace).

Well, something broke...  It doesn't take much imagination to go
from the breaking \x: in the mmix test-case to e.g. a macro with
a \x*2 in the macro body and a target with "*" in the symbol
character set.  Or "+", or...

You changed behavior of macro (names, parameters), so I think
it's only prudent to document the change even (certainly a
gas/NEWS item) if only vaguely saying that an artificial
restriction on symbols in macro names and parameters has been
lifted.

brgds, H-P

  reply	other threads:[~2005-02-09 10:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-09 14:32 Jan Beulich
2005-02-09 15:03 ` Hans-Peter Nilsson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-04-11 12:48 Jan Beulich
2005-03-29 16:26 Jan Beulich
2005-04-01 14:30 ` Nick Clifton
     [not found] <s225d5fa.098@emea1-mh.id2.novell.com>
2005-03-02 15:20 ` Ian Lance Taylor
2005-03-02 15:04 Jan Beulich
2005-03-02  8:28 Jan Beulich
2005-03-02 14:42 ` Ian Lance Taylor
2005-02-28 19:22 Jan Beulich
2005-02-28 23:47 ` Hans-Peter Nilsson
2005-02-28 13:37 Jan Beulich
2005-02-28 17:14 ` Hans-Peter Nilsson
     [not found]   ` <20050228222944.GF5299@bubble.modra.org>
2005-03-01  6:27     ` Hans-Peter Nilsson
2005-03-01  6:45       ` Hans-Peter Nilsson
2005-03-01  7:07       ` Alan Modra
     [not found] <s209d602.092@emea1-mh.id2.novell.com>
2005-02-09 14:14 ` Hans-Peter Nilsson
     [not found] <s209c6d8.000@emea1-mh.id2.novell.com>
2005-02-09 14:11 ` Hans-Peter Nilsson
2005-02-09 14:06 Jan Beulich
     [not found] <s209c8b9.060@emea1-mh.id2.novell.com>
2005-02-09 11:42 ` Hans-Peter Nilsson
2005-02-09 11:32 Jan Beulich
2005-02-09 10:28 Jan Beulich
2005-02-08 20:55 Jan Beulich
2005-02-08 23:05 ` Hans-Peter Nilsson
2005-02-08 23:58 ` Hans-Peter Nilsson
2005-02-08 17:52 Jan Beulich
2005-02-08 20:22 ` Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.BSF.4.58.0502090518430.2582@dair.pair.com \
    --to=hp@bitrange.com \
    --cc=JBeulich@novell.com \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).