From: "Jan Beulich" <JBeulich@novell.com>
To: <hp@bitrange.com>
Cc: <binutils@sources.redhat.com>
Subject: Re: [PATCH] Re: .macro behavior
Date: Tue, 08 Feb 2005 20:55:00 -0000 [thread overview]
Message-ID: <s208f484.036@emea1-mh.id2.novell.com> (raw)
>> >> only allows [[:alpha:]_$][[:alnum:]_$]*
>
>I think this restriction is actually good. Calls for the least
>amount of surprises when applying the same macro to different
>GAS ports.
Not so. If, on IA-64 as an example, I want to define an
instruction-like macro, I need to have '.' as an acceptable character
for the macro name.
>> * gas/mmix/relax2.s: Use .altmacro and & to separate macro
>> parameter
>> references.
>
>Ew. Please just get rid of the ":"s instead (my mistake, as
>it's a symbol character, not the usual label-ending thingy).
I can't: The test just fails (with an error message that says nothing
to me) if I do so.
>And a nitpick:
>
>>
/home/jbeulich/src/binutils/mainline/2005-02-01/gas/testsuite/gas/mmix/relax2.s 2003-10-18
>> 18:00:21.000000000 +0200
>> +++ 2005-02-01/gas/testsuite/gas/mmix/relax2.s 2005-02-08
>> 09:38:12.000000000 +0100
>> @@ -1,35 +1,37 @@
>> # PUSHJ stub border-cases: two with either or both stubs
unreachable,
>> # local symbols, ditto non-local labels, similar with three
PUSHJs.
>>
>> +.altmacro
>> +
>
>Pseudos shouldn't be first on a line. Accepting it in gas is ok,
>but we shouldn't get sloppy in the test-suite. For consistency,
>it should also be aligned with the other pseudos in that file.
>(I guess you don't need the ".altmacro" pseudo if you just
>remove the ":"s so this is mostly for the record.)
Will do.
Thanks, Jan
next reply other threads:[~2005-02-08 17:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-08 20:55 Jan Beulich [this message]
2005-02-08 23:05 ` Hans-Peter Nilsson
2005-02-08 23:58 ` Hans-Peter Nilsson
-- strict thread matches above, loose matches on Subject: below --
2005-04-11 12:48 Jan Beulich
2005-03-29 16:26 Jan Beulich
2005-04-01 14:30 ` Nick Clifton
[not found] <s225d5fa.098@emea1-mh.id2.novell.com>
2005-03-02 15:20 ` Ian Lance Taylor
2005-03-02 15:04 Jan Beulich
2005-03-02 8:28 Jan Beulich
2005-03-02 14:42 ` Ian Lance Taylor
2005-02-28 19:22 Jan Beulich
2005-02-28 23:47 ` Hans-Peter Nilsson
2005-02-28 13:37 Jan Beulich
2005-02-28 17:14 ` Hans-Peter Nilsson
[not found] ` <20050228222944.GF5299@bubble.modra.org>
2005-03-01 6:27 ` Hans-Peter Nilsson
2005-03-01 6:45 ` Hans-Peter Nilsson
2005-03-01 7:07 ` Alan Modra
2005-02-09 14:32 Jan Beulich
2005-02-09 15:03 ` Hans-Peter Nilsson
[not found] <s209d602.092@emea1-mh.id2.novell.com>
2005-02-09 14:14 ` Hans-Peter Nilsson
[not found] <s209c6d8.000@emea1-mh.id2.novell.com>
2005-02-09 14:11 ` Hans-Peter Nilsson
2005-02-09 14:06 Jan Beulich
[not found] <s209c8b9.060@emea1-mh.id2.novell.com>
2005-02-09 11:42 ` Hans-Peter Nilsson
2005-02-09 11:32 Jan Beulich
2005-02-09 10:28 Jan Beulich
2005-02-08 17:52 Jan Beulich
2005-02-08 20:22 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s208f484.036@emea1-mh.id2.novell.com \
--to=jbeulich@novell.com \
--cc=binutils@sources.redhat.com \
--cc=hp@bitrange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).