public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Re: .macro behavior
Date: Fri, 01 Apr 2005 14:30:00 -0000	[thread overview]
Message-ID: <424D5A42.4090803@redhat.com> (raw)
In-Reply-To: <s2498374.062@emea1-mh.id2.novell.com>

Hi Jan,

> gas/
> 2005-03-29  Jan Beulich  <jbeulich@novell.com>
> 
> 	* NEWS: Mention these changes and their effects.
> 	* macro.c (get_token): Use is_name_beginner/is_part_of_name/
> 	is_name_ender.
> 	(check_macro): Likewise.
> 	(buffer_and_nest): Likewise. Permit multiple labels. Don't discard
> 	labels together with the closing pseudo-op.
> 	(macro_expand_body): Adjust comment. Range-check input before use.
> 	Adjust mis-spelled diagnostic. Use is_name_beginner.
> 	* read.c (try_macro): New.
> 	(read_a_source_file): New static variable last_eol. Don't list
> 	macro expansion lines more than once. Call try_macro.
> 	(s_macro): Set section of line_label to absolute instead of undefined.
> 
> gas/testsuite/
> 2005-03-29  Jan Beulich  <jbeulich@novell.com>
> 
> 	* gas/macros/dot.[ls]: New.
> 	* gas/macros/macros.exp: Run new test.

Approved - please apply.

One request though.  Would it be possible to add entry to the assembler 
documentation about this new feature, and in particular a lengthier 
description of:

"...this is known to cause problems in certain sources when the
  respective target uses characters inconsistently, and thus macro
  parameter references are no longer recognized as such."

With an example and a suggested workaround.

Cheers
   Nick

  reply	other threads:[~2005-04-01 14:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-29 16:26 Jan Beulich
2005-04-01 14:30 ` Nick Clifton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-04-11 12:48 Jan Beulich
     [not found] <s225d5fa.098@emea1-mh.id2.novell.com>
2005-03-02 15:20 ` Ian Lance Taylor
2005-03-02 15:04 Jan Beulich
2005-03-02  8:28 Jan Beulich
2005-03-02 14:42 ` Ian Lance Taylor
2005-02-28 19:22 Jan Beulich
2005-02-28 23:47 ` Hans-Peter Nilsson
2005-02-28 13:37 Jan Beulich
2005-02-28 17:14 ` Hans-Peter Nilsson
     [not found]   ` <20050228222944.GF5299@bubble.modra.org>
2005-03-01  6:27     ` Hans-Peter Nilsson
2005-03-01  6:45       ` Hans-Peter Nilsson
2005-03-01  7:07       ` Alan Modra
2005-02-09 14:32 Jan Beulich
2005-02-09 15:03 ` Hans-Peter Nilsson
     [not found] <s209d602.092@emea1-mh.id2.novell.com>
2005-02-09 14:14 ` Hans-Peter Nilsson
     [not found] <s209c6d8.000@emea1-mh.id2.novell.com>
2005-02-09 14:11 ` Hans-Peter Nilsson
2005-02-09 14:06 Jan Beulich
     [not found] <s209c8b9.060@emea1-mh.id2.novell.com>
2005-02-09 11:42 ` Hans-Peter Nilsson
2005-02-09 11:32 Jan Beulich
2005-02-09 10:28 Jan Beulich
2005-02-08 20:55 Jan Beulich
2005-02-08 23:05 ` Hans-Peter Nilsson
2005-02-08 23:58 ` Hans-Peter Nilsson
2005-02-08 17:52 Jan Beulich
2005-02-08 20:22 ` Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=424D5A42.4090803@redhat.com \
    --to=nickc@redhat.com \
    --cc=JBeulich@novell.com \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).