Patch to add objdump to TOOL_PROGS

Patch to add objdump to TOOL_PROGS

[Joseph S. Myers]

This patch adds objdump to TOOL_PROGS so a link to it gets installed
in tooldir.

A case where this is of use is building and testing GCC on
hppa64-hpux, where tooldir followed by bindir are at the start of the
PATH with both 32-bit and 64-bit binutils installed under the same
prefix; objdump in bindir is 32-bit HPPA (SOM) objdump and the 64-bit
objdump is bindir/hppa64-hp-hpux11.xx-objdump.  The GCC testsuite
expects to find objdump (not target-objdump) in the PATH, if not
building binutils in a unified tree, in order to identify the object
file format, so it finds the SOM objdump which fails to identify the
64-bit file format as ELF.  Having a link to objdump in tooldir solves
this problem.

Tested on i686-pc-linux-gnu.  OK to commit?

-- 
Joseph S. Myers
joseph@codesourcery.com

2005-02-17  Joseph S. Myers  <joseph@codesourcery.com>

	* Makefile.am (TOOL_PROGS): Add objdump.
	* Makefile.in: Regenerate.

diff -rupN binutils.orig/Makefile.am binutils/Makefile.am
--- binutils.orig/Makefile.am	2004-12-01 10:54:51.000000000 +0000
+++ binutils/Makefile.am	2005-02-17 20:35:23.000000000 +0000
@@ -63,7 +63,7 @@ noinst_PROGRAMS = $(NM_PROG) $(STRIP_PRO
 EXTRA_PROGRAMS = $(NLMCONV_PROG) srconv sysdump coffdump $(DLLTOOL_PROG) $(WINDRES_PROG) $(DLLWRAP_PROG)
 
 # Stuff that goes in tooldir/ if appropriate.
-TOOL_PROGS = nm-new strip-new ar ranlib dlltool
+TOOL_PROGS = nm-new strip-new ar ranlib dlltool objdump
 
 BASEDIR = $(srcdir)/..
 BFDDIR = $(BASEDIR)/bfd
diff -rupN binutils.orig/Makefile.in binutils/Makefile.in
--- binutils.orig/Makefile.in	2004-12-01 10:54:51.000000000 +0000
+++ binutils/Makefile.in	2005-02-17 20:35:39.000000000 +0000
@@ -184,7 +184,7 @@ noinst_PROGRAMS = $(NM_PROG) $(STRIP_PRO
 EXTRA_PROGRAMS = $(NLMCONV_PROG) srconv sysdump coffdump $(DLLTOOL_PROG) $(WINDRES_PROG) $(DLLWRAP_PROG)
 
 # Stuff that goes in tooldir/ if appropriate.
-TOOL_PROGS = nm-new strip-new ar ranlib dlltool
+TOOL_PROGS = nm-new strip-new ar ranlib dlltool objdump
 
 BASEDIR = $(srcdir)/..
 BFDDIR = $(BASEDIR)/bfd

Re: Patch to add objdump to TOOL_PROGS

[Alan Modra]

On Thu, Feb 17, 2005 at 08:50:25PM +0000, Joseph S. Myers wrote:
> This patch adds objdump to TOOL_PROGS so a link to it gets installed
> in tooldir.

Please apply.

> The GCC testsuite
> expects to find objdump (not target-objdump) in the PATH, if not
> building binutils in a unified tree

Sound like a bug that needs fixing too.  Why doesn't gcc first try for
target-objdump?

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: Patch to add objdump to TOOL_PROGS

[Joseph S. Myers]

On Fri, 18 Feb 2005, Alan Modra wrote:

> > The GCC testsuite
> > expects to find objdump (not target-objdump) in the PATH, if not
> > building binutils in a unified tree
> 
> Sound like a bug that needs fixing too.  Why doesn't gcc first try for
> target-objdump?

I think because it's testing a native configuration and 
runtest.exp:transform (called from libgloss.exp:find_binutils_prog) only 
uses the target- prefix for cross-compilations.  But it would probably 
make sense for DejaGnu to try the prefix first even for native 
compilations.

(The HPPA HP-UX case of trying to have both 32-bit and 64-bit tools in a 
common prefix is a somewhat peculiar case; most cases of systems 
supporting both 32-bit and 64-bit models would have a single set of tools 
supporting both and compile with -m32 or -m64 to use the non-default 
model, but in the HPPA HP-UX case 32-bit uses SOM and 64-bit uses ELF and 
this difference makes things more difficult.)

-- 
Joseph S. Myers
joseph@codesourcery.com