From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Both FAIL and PASS "check sections 2"?
Date: Tue, 21 Feb 2023 16:23:58 +1030 [thread overview]
Message-ID: <Y/RcdkYHUwcnAETA@squeak.grove.modra.org> (raw)
* testsuite/ld-checks/checks.exp (check sections 2): Don't
continue on with rest of test past first fail.
diff --git a/ld/testsuite/ld-checks/checks.exp b/ld/testsuite/ld-checks/checks.exp
index a0b6ade00c3..52b4088637a 100644
--- a/ld/testsuite/ld-checks/checks.exp
+++ b/ld/testsuite/ld-checks/checks.exp
@@ -61,17 +61,18 @@ proc section_check {} {
# Make sure that we got some output from the linker
if [string match "" $exec_output] then {
fail $test
- }
+ } else {
- # Now remove our expected error message
- regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output
+ # Now remove our expected error message
+ regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output
- # And check to see if anything else, (unexpected) was left
- if [string match "" $exec_output] then {
- pass $test
- } else {
- verbose -log "Unexpected linker message(s): $exec_output"
- fail $test
+ # And check to see if anything else, (unexpected) was left
+ if [string match "" $exec_output] then {
+ pass $test
+ } else {
+ verbose -log "Unexpected linker message(s): $exec_output"
+ fail $test
+ }
}
}
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2023-02-21 5:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/RcdkYHUwcnAETA@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).