public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Both FAIL and PASS "check sections 2"?
@ 2023-02-21  5:53 Alan Modra
  0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2023-02-21  5:53 UTC (permalink / raw)
  To: binutils

	* testsuite/ld-checks/checks.exp (check sections 2): Don't
	continue on with rest of test past first fail.

diff --git a/ld/testsuite/ld-checks/checks.exp b/ld/testsuite/ld-checks/checks.exp
index a0b6ade00c3..52b4088637a 100644
--- a/ld/testsuite/ld-checks/checks.exp
+++ b/ld/testsuite/ld-checks/checks.exp
@@ -61,17 +61,18 @@ proc section_check {} {
     # Make sure that we got some output from the linker
     if [string match "" $exec_output] then {
 	fail $test
-    }
+    } else {
 
-    # Now remove our expected error message
-    regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output
+	# Now remove our expected error message
+	regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output
 
-    # And check to see if anything else, (unexpected) was left
-    if [string match "" $exec_output] then {
-	pass $test
-    } else {
-	verbose -log "Unexpected linker message(s): $exec_output"
-	fail $test
+	# And check to see if anything else, (unexpected) was left
+	if [string match "" $exec_output] then {
+	    pass $test
+	} else {
+	    verbose -log "Unexpected linker message(s): $exec_output"
+	    fail $test
+	}
     }
 }
 

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-21  5:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-21  5:53 Both FAIL and PASS "check sections 2"? Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).