From: Mike Frysinger <vapier@gentoo.org>
To: Brett Werling <bwerl.dev@gmail.com>
Cc: Michael Matz <matz@suse.de>, Jan Beulich <jbeulich@suse.com>,
Alan Modra <amodra@gmail.com>,
binutils@sourceware.org
Subject: Re: [PATCH] readelf: use fseeko for elf files >= 2 GiB on x86_64-mingw32
Date: Thu, 17 Nov 2022 15:02:43 +0700 [thread overview]
Message-ID: <Y3Xqo5Hb72k7GfcK@vapier> (raw)
In-Reply-To: <CAMEwLB1YKbTXgB5W7+4jck0-_iTeAq_8gixoNg4_3J_Y54REXA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2204 bytes --]
On 16 Nov 2022 15:19, Brett Werling via Binutils wrote:
> On Wed, Nov 16, 2022 at 11:09 AM Mike Frysinger wrote:
> > On 16 Nov 2022 16:13, Michael Matz wrote:
> > > On Wed, 16 Nov 2022, Mike Frysinger wrote:
> > > > are you claiming that current gnulib versions can't support even those old
> > > > versions of glibc ? i'd find that extremely surprising, and really sounds
> > > > like a bug that should be taken up with the gnulib folks.
> > >
> > > No. I'm claiming that moving to gnulib is work (even if perhaps not
> > > much?) and change and I (personally) don't see the need to invest into
> > > that work and deal with the change. Had you asked "should I look into
> > > using gnulib in bfd" my answer would have been "well, try it, why not?".
> > > But you asked "should _we_ look" (aka should someone do that), hence my
> > > answer was in the line of "perhaps, but why bother?".
> >
> > you're proposing adding a not insignificant amount of custom portability logic
> > and making the readelf code harder to understand & maintain while also not
> > fixing the same bug in other binutils/ tools. it is perfectly reasonable to
> > ask you to not add tech debt & make the code base worse off for everyone else
> > to maintain, and instead focus on a common solution that the GNU project is
> > already heavily invested in. this is, of course, the "GNU Binutils" project.
>
> I must admit, I'm quite unfamiliar with the history here and my
> original intention
> was to just provide a solution to a specific issue I found with
> readelf. Anything
> beyond that is probably outside the scope of what I'm comfortable addressing.
> If someone else wants to take what I've started here and drive it to completion
> as part of a larger effort, please feel free!
>
> Also wanted to make sure that my second patch was seen? I think it addresses
> the original concern raised by Jan, but perhaps more is still needed there.
the 2nd patch is what prompted me to follow up to the thread ;). i grok that
it addresses the specific issue you've found, but it isn't a complete fix, nor
one that improves the codebase for the maintainers to maintain long term.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-17 8:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 15:03 Brett Werling
2022-11-14 15:30 ` Jan Beulich
2022-11-14 15:52 ` Brett Werling
2022-11-14 21:42 ` Alan Modra
2022-11-16 10:09 ` Mike Frysinger
2022-11-16 10:46 ` Jan Beulich
2022-11-16 14:01 ` Mike Frysinger
2022-11-16 14:44 ` Michael Matz
2022-11-16 15:40 ` Mike Frysinger
2022-11-16 15:58 ` Jose E. Marchesi
2022-11-16 16:13 ` Michael Matz
2022-11-16 17:09 ` Mike Frysinger
2022-11-16 21:19 ` Brett Werling
2022-11-17 8:02 ` Mike Frysinger [this message]
2022-11-17 13:21 ` Michael Matz
2022-11-15 14:57 ` [PATCH] readelf: use fseeko64 or fseeko if possible Brett Werling
2022-11-17 7:02 ` Alan Modra
2022-11-17 14:09 ` Brett Werling
2022-11-17 14:34 ` Brett Werling
2022-11-21 21:52 ` Alan Modra
2022-11-22 13:46 ` Michael Matz
2022-11-22 21:55 ` Alan Modra
2022-11-22 21:57 ` Alan Modra
2022-11-22 21:59 ` Don't use "long" in readelf for file offsets Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Xqo5Hb72k7GfcK@vapier \
--to=vapier@gentoo.org \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=bwerl.dev@gmail.com \
--cc=jbeulich@suse.com \
--cc=matz@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).