Re: [PATCH] readelf: use fseeko for elf files >= 2 GiB on x86_64-mingw32

[Michael Matz <matz@suse.de>]

Hello,

On Wed, 16 Nov 2022, Mike Frysinger via Binutils wrote:

> > >>> I think you are correct, this will need some conditional logic to be "safe"
> > >>> to
> > >>> include, and even then the casting to off_t would become a little more
> > >>> complicated. I will look deeper into what can be done here.
> > >>
> > >> See bfd/bfdio.c and bfd/configure.ac
> > > 
> > > should we look at bfd using gnulib ?

The patch is for readelf, which doesn't use libbfd.  (And if readelf 
should use gnulib for this?  I don't know, seems overkill for a single 
function).

> > > growing our own portability layer sounds
> > > like a lot of dupicative effort ...

I think "growing" and "lot of" don't describe the effort.  Rewriting to 
use gnulib (and the corresponding necessary testing) might be trivial as 
well (though I don't think so), but the returns are still very small.

> realistically, is anyone actually testing those old distros ?

Depends on the definition of old.  For instance our oldish enterprise 
stuff (SLES12) still has current binutils, so at least there it's tested 
relatively good.  OTOH it's only 9 years old, so some might say that 
doesn't qualify :)


Ciao,
Michael.