From: Michael Matz <matz@suse.de>
To: Alan Modra <amodra@gmail.com>
Cc: Brett Werling <bwerl.dev@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH] readelf: use fseeko64 or fseeko if possible
Date: Tue, 22 Nov 2022 13:46:56 +0000 (UTC) [thread overview]
Message-ID: <alpine.LSU.2.20.2211221305570.5466@wotan.suse.de> (raw)
In-Reply-To: <Y3vzKgQSiTQCNVQc@squeak.grove.modra.org>
Hey Alan,
On Tue, 22 Nov 2022, Alan Modra via Binutils wrote:
> On Thu, Nov 17, 2022 at 08:34:19AM -0600, Brett Werling via Binutils wrote:
> > Changes readelf to make use first of fseeko64 and then fseeko,
> > depending on which of those is available. If neither is available,
> > reverts to the previous behavior of using fseek.
>
> Committed, thanks.
I've integrated the change into configure.ac and regen'ed
config{ure,.in} and pushed d7229d6a561 for this.
(Brett: in case you wonder: configure and config.in are generated files,
by autoconf, so editing them directly would eventually lose the changes on
the next regeneration, configure.ac is the source file for them)
Ciao,
Michael.
next prev parent reply other threads:[~2022-11-22 13:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 15:03 [PATCH] readelf: use fseeko for elf files >= 2 GiB on x86_64-mingw32 Brett Werling
2022-11-14 15:30 ` Jan Beulich
2022-11-14 15:52 ` Brett Werling
2022-11-14 21:42 ` Alan Modra
2022-11-16 10:09 ` Mike Frysinger
2022-11-16 10:46 ` Jan Beulich
2022-11-16 14:01 ` Mike Frysinger
2022-11-16 14:44 ` Michael Matz
2022-11-16 15:40 ` Mike Frysinger
2022-11-16 15:58 ` Jose E. Marchesi
2022-11-16 16:13 ` Michael Matz
2022-11-16 17:09 ` Mike Frysinger
2022-11-16 21:19 ` Brett Werling
2022-11-17 8:02 ` Mike Frysinger
2022-11-17 13:21 ` Michael Matz
2022-11-15 14:57 ` [PATCH] readelf: use fseeko64 or fseeko if possible Brett Werling
2022-11-17 7:02 ` Alan Modra
2022-11-17 14:09 ` Brett Werling
2022-11-17 14:34 ` Brett Werling
2022-11-21 21:52 ` Alan Modra
2022-11-22 13:46 ` Michael Matz [this message]
2022-11-22 21:55 ` Alan Modra
2022-11-22 21:57 ` Alan Modra
2022-11-22 21:59 ` Don't use "long" in readelf for file offsets Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.2211221305570.5466@wotan.suse.de \
--to=matz@suse.de \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=bwerl.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).