From: Mike Frysinger <vapier@gentoo.org>
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/2] libctf: remove unnecessary zlib constructs
Date: Sat, 10 Dec 2022 10:07:48 +0900 [thread overview]
Message-ID: <Y5Pb5CtPuEPiJeXw@vapier> (raw)
In-Reply-To: <20221209202118.4106688-2-indu.bhagat@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
On 09 Dec 2022 12:21, Indu Bhagat via Binutils wrote:
> -ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'`
> -LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
> +LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
$ZLIBDIR is zlib related ...
> -LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS"
> +LIBS="-lbfd -liberty $intl $LIBS"
... but $ZSTD_LIBS is zstd related, not zlib.
commit message only says zlib.
also, you're still calling AM_ZLIB & AC_ZSTD which should be removed.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-12-10 1:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 20:21 [PATCH 0/2] Small improvements to libctf configure.ac Indu Bhagat
2022-12-09 20:21 ` [PATCH 1/2] libctf: remove unnecessary zlib constructs Indu Bhagat
2022-12-10 1:07 ` Mike Frysinger [this message]
2022-12-10 6:55 ` Indu Bhagat
2022-12-09 20:21 ` [PATCH 2/2] libctf: remove AC_CONFIG_MACRO_DIR Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5Pb5CtPuEPiJeXw@vapier \
--to=vapier@gentoo.org \
--cc=binutils@sourceware.org \
--cc=indu.bhagat@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).