From: Indu Bhagat <indu.bhagat@oracle.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/2] libctf: remove unnecessary zlib constructs
Date: Fri, 9 Dec 2022 22:55:27 -0800 [thread overview]
Message-ID: <dbf5ba14-e918-b675-0b0c-27ecce0793d9@oracle.com> (raw)
In-Reply-To: <Y5Pb5CtPuEPiJeXw@vapier>
On 12/9/22 17:07, Mike Frysinger wrote:
> On 09 Dec 2022 12:21, Indu Bhagat via Binutils wrote:
>> -ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'`
>> -LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
>> +LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
>
> $ZLIBDIR is zlib related ...
>
>> -LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS"
>> +LIBS="-lbfd -liberty $intl $LIBS"
>
> ... but $ZSTD_LIBS is zstd related, not zlib.
>
> commit message only says zlib.
>
Oops, yes, the removal of $ZSTD_LIBS was unintentional.
> also, you're still calling AM_ZLIB & AC_ZSTD which should be removed.
> -mike
AM_ZLIB cannot be removed at this time from libctf/configure.ac. There
was a discussion earlier on this matter in context of using libtool and
GDB: https://sourceware.org/pipermail/gdb-patches/2022-November/193771.html
Regarding removal of AC_ZSTD, perhaps, yes. I will run some tests and
send a separate patch.
Thanks!
next prev parent reply other threads:[~2022-12-10 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 20:21 [PATCH 0/2] Small improvements to libctf configure.ac Indu Bhagat
2022-12-09 20:21 ` [PATCH 1/2] libctf: remove unnecessary zlib constructs Indu Bhagat
2022-12-10 1:07 ` Mike Frysinger
2022-12-10 6:55 ` Indu Bhagat [this message]
2022-12-09 20:21 ` [PATCH 2/2] libctf: remove AC_CONFIG_MACRO_DIR Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbf5ba14-e918-b675-0b0c-27ecce0793d9@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).