public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* cgen: increase buffer for hash_insn_list
@ 2022-05-12  3:55 Alan Modra
  0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2022-05-12  3:55 UTC (permalink / raw)
  To: binutils

As was done for hash_insn_array in commit d3d1cc7b13b4.

	* cgen-dis.c (hash_insn_list): Increase size of buf.  Assert
	size is large enough.

diff --git a/opcodes/cgen-dis.c b/opcodes/cgen-dis.c
index 4137e39bd38..993deeb26b4 100644
--- a/opcodes/cgen-dis.c
+++ b/opcodes/cgen-dis.c
@@ -153,8 +153,9 @@ hash_insn_list (CGEN_CPU_DESC cd,
   for (ilist = insns; ilist != NULL; ilist = ilist->next, ++ hentbuf)
     {
       unsigned int hash;
-      char buf[4];
+      char buf[8];
       unsigned long value;
+      size_t size;
 
       if (! (* cd->dis_hash_p) (ilist->insn))
 	continue;
@@ -163,10 +164,9 @@ hash_insn_list (CGEN_CPU_DESC cd,
 	 to hash on, so set both up.  */
 
       value = CGEN_INSN_BASE_VALUE (ilist->insn);
-      bfd_put_bits((bfd_vma) value,
-		   buf,
-		   CGEN_INSN_MASK_BITSIZE (ilist->insn),
-		   big_p);
+      size = CGEN_INSN_MASK_BITSIZE (ilist->insn);
+      OPCODES_ASSERT (size <= sizeof (buf) * 8);
+      bfd_put_bits ((bfd_vma) value, buf, size, big_p);
       hash = (* cd->dis_hash) (buf, value);
       add_insn_to_hash_chain (hentbuf, ilist->insn, htable, hash);
     }

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-12  3:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12  3:55 cgen: increase buffer for hash_insn_list Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).