public inbox for
 help / color / mirror / Atom feed
From: Mike Frysinger <>
To: Stafford Horne <>
Cc: GNU Binutils <>,
	Linux OpenRISC <>
Subject: Re: [PATCH] sim: or1k: Eliminate dangerous RWX load segments
Date: Fri, 13 Oct 2023 17:20:55 +0545	[thread overview]
Message-ID: <ZSkrm9jO8ljxhpal@vapier> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]

On 19 Aug 2023 08:45, Stafford Horne wrote:
> This fixes test failures caused by the new linker warning which report:
>   ./ld/ld-new: warning: load.S.x has a LOAD segment with RWX permissions
> Fix this by splitting the linker MEMORY into ram and rom to avoid
> generating RWX sections.  This required tests to be adjusted to fix
> issues with the move.  Namely:
>   - fpu tests: were incorrectly using l.ori with ha(anchor) which now
>     that we pushed the anchor up in memory it exposes the bug.  Update
>     to used the correct l.movhi instruction instead.
>   - adrp test: the test reports ram offset addresses, now that we have
>     moved memory layout around a bit I adjusted the test output.  Some
>     padding is added before pi to show that the actual address of pi and
>     the adrp page offset are not the same.
> Bug:

nit: put [PR sim/29957] at the end of the git commit summary (first line)

otherwise, lgtm, thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  parent reply	other threads:[~2023-10-13 11:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-19  7:45 Stafford Horne
2023-08-21 15:13 ` Nick Clifton
2023-10-13 11:35 ` Mike Frysinger [this message]
2023-10-14  6:30   ` Stafford Horne
2023-10-14  8:26     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZSkrm9jO8ljxhpal@vapier \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).