From: Mike Frysinger <vapier@gentoo.org>
To: Stafford Horne <shorne@gmail.com>
Cc: GNU Binutils <binutils@sourceware.org>,
Linux OpenRISC <linux-openrisc@vger.kernel.org>
Subject: Re: [PATCH] sim: or1k: Eliminate dangerous RWX load segments
Date: Sat, 14 Oct 2023 14:11:24 +0545 [thread overview]
Message-ID: <ZSpQsN+RDzykf0iu@vapier> (raw)
In-Reply-To: <ZSo1iv/ob7D8VRQj@antec>
[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]
On 14 Oct 2023 07:30, Stafford Horne wrote:
> On Fri, Oct 13, 2023 at 05:20:55PM +0545, Mike Frysinger wrote:
> > On 19 Aug 2023 08:45, Stafford Horne wrote:
> > > This fixes test failures caused by the new linker warning which report:
> > >
> > > ./ld/ld-new: warning: load.S.x has a LOAD segment with RWX permissions
> > >
> > > Fix this by splitting the linker MEMORY into ram and rom to avoid
> > > generating RWX sections. This required tests to be adjusted to fix
> > > issues with the move. Namely:
> > >
> > > - fpu tests: were incorrectly using l.ori with ha(anchor) which now
> > > that we pushed the anchor up in memory it exposes the bug. Update
> > > to used the correct l.movhi instruction instead.
> > > - adrp test: the test reports ram offset addresses, now that we have
> > > moved memory layout around a bit I adjusted the test output. Some
> > > padding is added before pi to show that the actual address of pi and
> > > the adrp page offset are not the same.
> > >
> > > Bug: https://sourceware.org/PR29957
> >
> > nit: put [PR sim/29957] at the end of the git commit summary (first line)
> >
> > otherwise, lgtm, thanks
> > -mike
>
> Thanks Mike,
>
> I actually pushed this long back without the above update after I read Nick's
> comment. I for some reason missed that he said he was forwarding to the sim
> maintainers.
>
> Sorry for that.
np. had some hardware failures on my main desktop so only just catching up.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-10-14 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 7:45 Stafford Horne
2023-08-21 15:13 ` Nick Clifton
2023-10-13 11:35 ` Mike Frysinger
2023-10-14 6:30 ` Stafford Horne
2023-10-14 8:26 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSpQsN+RDzykf0iu@vapier \
--to=vapier@gentoo.org \
--cc=binutils@sourceware.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).