From: Tom de Vries <tdevries@suse.de>
To: Nick Clifton <nickc@redhat.com>, Andreas Schwab <schwab@suse.de>,
Tom de Vries via Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] [gas] Emit v2 .debug_line for -gdwarf-2
Date: Tue, 31 Jan 2023 14:56:18 +0100 [thread overview]
Message-ID: <a46e321c-e763-4bd0-8118-4b7f52df31d3@suse.de> (raw)
In-Reply-To: <69336084-4fe7-0030-cf5b-968804af9954@redhat.com>
On 1/31/23 14:38, Nick Clifton wrote:
> Hi Tom,
>
>> I've updated the comment, and I've also updated the macro definition to:
>> ...
>> #define DWARF2_LINE_VERSION DWARF2_VERSION
>
> Does this mean that DWARF2_LINE_VERSION is now redundant, and
> could just be replaced with DWARF2_VERSION ?
>
I suppose so, though when using DWARF2_LINE_VERSION it's immediate clear
what it means. With using DWARF2_VERSION when dealing .debug_lines, you
need to know/remember/lookup that the version is the same for the two.
> Anyway, patch approved - please apply.
Thanks, I'll commit then.
- Tom
prev parent reply other threads:[~2023-01-31 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 11:42 Tom de Vries
2023-01-31 11:55 ` Andreas Schwab
2023-01-31 12:26 ` Tom de Vries
2023-01-31 13:38 ` Nick Clifton
2023-01-31 13:56 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a46e321c-e763-4bd0-8118-4b7f52df31d3@suse.de \
--to=tdevries@suse.de \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).