From: Andreas Schwab <schwab@suse.de>
To: Tom de Vries via Binutils <binutils@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH] [gas] Emit v2 .debug_line for -gdwarf-2
Date: Tue, 31 Jan 2023 12:55:12 +0100 [thread overview]
Message-ID: <mvm8rhizzof.fsf@suse.de> (raw)
In-Reply-To: <20230131114257.4585-1-tdevries@suse.de> (Tom de Vries via Binutils's message of "Tue, 31 Jan 2023 12:42:57 +0100")
On Jan 31 2023, Tom de Vries via Binutils wrote:
> Fix this by emitting a v3 .debug_line contribution instead.
s/v3/v2/?
> diff --git a/gas/dwarf2dbg.c b/gas/dwarf2dbg.c
> index c7d9e8ef72f..e6c411426af 100644
> --- a/gas/dwarf2dbg.c
> +++ b/gas/dwarf2dbg.c
> @@ -88,7 +88,7 @@
>
> /* This implementation outputs version 3 .debug_line information. */
> #ifndef DWARF2_LINE_VERSION
> -#define DWARF2_LINE_VERSION (dwarf_level > 3 ? dwarf_level : 3)
> +#define DWARF2_LINE_VERSION dwarf_level
Seems like the comment is no longer accurate.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2023-01-31 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 11:42 Tom de Vries
2023-01-31 11:55 ` Andreas Schwab [this message]
2023-01-31 12:26 ` Tom de Vries
2023-01-31 13:38 ` Nick Clifton
2023-01-31 13:56 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm8rhizzof.fsf@suse.de \
--to=schwab@suse.de \
--cc=binutils@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).