From: Hans-Peter Nilsson <hp@bitrange.com>
To: Huang Pei <huangpei@loongson.cn>
Cc: Zhensong Liu <liuzhensong@loongson.cn>,
Chenghua Xu <xuchenghua@loongson.cn>,
binutils <binutils@sourceware.org>
Subject: Re: [PATCH] partial revert 5a91f93b983184c64b3a9332f5f4339d17941d76
Date: Fri, 13 May 2022 18:59:34 -0400 (EDT) [thread overview]
Message-ID: <alpine.BSF.2.20.16.2205131655010.6610@arjuna.pair.com> (raw)
In-Reply-To: <20220512023343.3411759-1-huangpei@loongson.cn>
The change is IMHO the right thing (I had noticed that
commented-out line that didn't look right), but:
On Thu, 12 May 2022, Huang Pei wrote:
> set elf_backend_default_execstack=0 on loongarch
...may I suggest that
"loongarch: Set elf_backend_default_execstack to 0"
or
"loongarch: Correct elf_backend_default_execstack to 0"
is a title better describing the change, than "partial revert ..."?
Alan's 5a91f93b9831 patch removed commented-out code (which if
un-commented would to what this patch does), so this patch
actually doesn't revert that change.
brgds, H-P
>
> Signed-off-by: Huang Pei <huangpei@loongson.cn>
> ---
> bfd/elfnn-loongarch.c | 1 +
> ld/testsuite/ld-elf/elf.exp | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> index 5b44901b9e0..4dcbb44e413 100644
> --- a/bfd/elfnn-loongarch.c
> +++ b/bfd/elfnn-loongarch.c
> @@ -130,6 +130,7 @@ struct loongarch_elf_link_hash_table
> #define elf_backend_got_header_size (GOT_ENTRY_SIZE * 1)
>
> #define elf_backend_want_dynrelro 1
> +#define elf_backend_default_execstack 0
>
> /* Generate a PLT header. */
>
> diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
> index ebb5ba090bf..e33a0d08831 100644
> --- a/ld/testsuite/ld-elf/elf.exp
> +++ b/ld/testsuite/ld-elf/elf.exp
> @@ -186,6 +186,7 @@ proc target_defaults_to_execstack {} {
> || [istarget "*-*-nacl"]
> || [istarget "arc*-*-*"]
> || [istarget "ia64*-*-*"]
> + || [istarget "loongarch*-*-*"]
> || [istarget "nios2*-*-*"]
> || [istarget "powerpc64*-*-*"]
> || [istarget "riscv*-*-*"]
> --
> 2.20.1
>
>
prev parent reply other threads:[~2022-05-13 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 2:33 Huang Pei
2022-05-13 22:59 ` Hans-Peter Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.20.16.2205131655010.6610@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=binutils@sourceware.org \
--cc=huangpei@loongson.cn \
--cc=liuzhensong@loongson.cn \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).