[PATCH] partial revert 5a91f93b983184c64b3a9332f5f4339d17941d76

[PATCH] partial revert 5a91f93b983184c64b3a9332f5f4339d17941d76

[Huang Pei]

set elf_backend_default_execstack=0 on loongarch

Signed-off-by: Huang Pei <huangpei@loongson.cn>
---
 bfd/elfnn-loongarch.c       | 1 +
 ld/testsuite/ld-elf/elf.exp | 1 +
 2 files changed, 2 insertions(+)

diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index 5b44901b9e0..4dcbb44e413 100644
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -130,6 +130,7 @@ struct loongarch_elf_link_hash_table
 #define elf_backend_got_header_size (GOT_ENTRY_SIZE * 1)
 
 #define elf_backend_want_dynrelro 1
+#define elf_backend_default_execstack 0
 
 /* Generate a PLT header.  */
 
diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
index ebb5ba090bf..e33a0d08831 100644
--- a/ld/testsuite/ld-elf/elf.exp
+++ b/ld/testsuite/ld-elf/elf.exp
@@ -186,6 +186,7 @@ proc target_defaults_to_execstack {} {
 	|| [istarget "*-*-nacl"]
 	|| [istarget "arc*-*-*"]
 	|| [istarget "ia64*-*-*"]
+	|| [istarget "loongarch*-*-*"]
 	|| [istarget "nios2*-*-*"]
 	|| [istarget "powerpc64*-*-*"]
 	|| [istarget "riscv*-*-*"]
-- 
2.20.1

Re: [PATCH] partial revert 5a91f93b983184c64b3a9332f5f4339d17941d76

[Hans-Peter Nilsson]

The change is IMHO the right thing (I had noticed that
commented-out line that didn't look right), but:

On Thu, 12 May 2022, Huang Pei wrote:
> set elf_backend_default_execstack=0 on loongarch

...may I suggest that
"loongarch: Set elf_backend_default_execstack to 0"
or
"loongarch: Correct elf_backend_default_execstack to 0"
is a title better describing the change, than "partial revert ..."?

Alan's 5a91f93b9831 patch removed commented-out code (which if
un-commented would to what this patch does), so this patch
actually doesn't revert that change.

brgds, H-P

>
> Signed-off-by: Huang Pei <huangpei@loongson.cn>
> ---
>  bfd/elfnn-loongarch.c       | 1 +
>  ld/testsuite/ld-elf/elf.exp | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> index 5b44901b9e0..4dcbb44e413 100644
> --- a/bfd/elfnn-loongarch.c
> +++ b/bfd/elfnn-loongarch.c
> @@ -130,6 +130,7 @@ struct loongarch_elf_link_hash_table
>  #define elf_backend_got_header_size (GOT_ENTRY_SIZE * 1)
>
>  #define elf_backend_want_dynrelro 1
> +#define elf_backend_default_execstack 0
>
>  /* Generate a PLT header.  */
>
> diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
> index ebb5ba090bf..e33a0d08831 100644
> --- a/ld/testsuite/ld-elf/elf.exp
> +++ b/ld/testsuite/ld-elf/elf.exp
> @@ -186,6 +186,7 @@ proc target_defaults_to_execstack {} {
>  	|| [istarget "*-*-nacl"]
>  	|| [istarget "arc*-*-*"]
>  	|| [istarget "ia64*-*-*"]
> +	|| [istarget "loongarch*-*-*"]
>  	|| [istarget "nios2*-*-*"]
>  	|| [istarget "powerpc64*-*-*"]
>  	|| [istarget "riscv*-*-*"]
> --
> 2.20.1
>
>