From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: david@davidgf.es
Cc: binutils@sourceware.org
Subject: Re: [PATCH 2/3] Add rotation instructions to allegrex CPU
Date: Sun, 7 May 2023 00:11:15 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2305062253170.54316@angie.orcam.me.uk> (raw)
In-Reply-To: <20230328230249.274759-3-david@davidgf.es>
On Wed, 29 Mar 2023, david@davidgf.es wrote:
> From: David Guillen Fandos <david@davidgf.net>
Again, at least a short introduction is needed here.
> diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
> index f28ea7e695..9f17f20643 100644
> --- a/gas/testsuite/gas/mips/mips.exp
> +++ b/gas/testsuite/gas/mips/mips.exp
> @@ -536,7 +536,7 @@ mips_arch_create xlr 64 mips64 { oddspreg } \
> mips_arch_create r5900 64 mips3 { gpr_ilocks singlefloat nollsc } \
> { -march=r5900 -mtune=r5900 } { -mmips:5900 } \
> { mipsr5900el-*-* mips64r5900el-*-* }
> -mips_arch_create allegrex 32 mips2 { singlefloat oddspreg } \
> +mips_arch_create allegrex 32 mips2 { singlefloat ror oddspreg } \
Please keep the flags in the same order as they're documented at the top
of the file, i.e. put `ror' ahead of `singlefloat'.
Otherwise this is OK.
Maciej
next prev parent reply other threads:[~2023-05-06 23:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 23:02 [PATCH 0/3] Add support for MIPS Allegrex david
2023-03-28 23:02 ` [PATCH 1/3] Add Allegrex CPU as a MIPS2-based CPU david
2023-05-06 23:11 ` Maciej W. Rozycki
2023-03-28 23:02 ` [PATCH 2/3] Add rotation instructions to allegrex CPU david
2023-05-06 23:11 ` Maciej W. Rozycki [this message]
2023-03-28 23:02 ` [PATCH 3/3] Adding more instructions to Allegrex CPU david
2023-05-06 23:11 ` Maciej W. Rozycki
2023-04-25 17:57 ` [PATCH 0/3] Add support for MIPS Allegrex David Guillen Fandos
2023-04-25 22:15 ` Maciej W. Rozycki
2023-05-06 8:03 ` David Guillen Fandos
2023-05-06 23:14 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2305062253170.54316@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=binutils@sourceware.org \
--cc=david@davidgf.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).