From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: David Guillen Fandos <david@davidgf.net>
Cc: binutils@sourceware.org, xuchenghua@loongson.cn
Subject: Re: [PATCH 0/3] Add support for MIPS Allegrex
Date: Sun, 7 May 2023 00:14:56 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2305062352510.54316@angie.orcam.me.uk> (raw)
In-Reply-To: <CADQAGROrOxK_XH2ETveHMUmNrqCdKMW2=N4+O_T8dpTHEkRPZg@mail.gmail.com>
On Sat, 6 May 2023, David Guillen Fandos wrote:
> > Thank you for pinging me directly, I'm not very up to date on mailing
> > list traffic right now. I'll review your submission over this coming
> > weekend.
>
> Awesome! Thank you very much! I'm looking forward to your review.
> I picked you since your name showed up in the MAINTAINERS file, but
> feel free to suggest any other person you think could be interested in
> the review.
I ran out of steam over the last weekend, so apologies for this delay.
Overall your code looks pretty good to me, I wish all submissions were so
good. I have spotted some minor issues however, please see my replies to
individual patches for details, and resubmit the changes with the problems
addressed.
I have pushed your changes through regression testing across my usual
MIPS targets and results were good except as noted in the replies.
There is one ouststanding concern as to the copyright to your changes.
There are two ways to move forward here, either by assigning the copyright
to the Free Software Foundation, or by agreeing to the Developer's
Certificate of Origin. Please review section "Patches and Copyright" in
binutils/MAINTAINERS and let me know what you have chosen. You may have
to update your submission accordingly.
In any case please let me know if you have any questions or concerns or
find anything what I wrote unclear.
Thank you for your submission.
Maciej
prev parent reply other threads:[~2023-05-06 23:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 23:02 david
2023-03-28 23:02 ` [PATCH 1/3] Add Allegrex CPU as a MIPS2-based CPU david
2023-05-06 23:11 ` Maciej W. Rozycki
2023-03-28 23:02 ` [PATCH 2/3] Add rotation instructions to allegrex CPU david
2023-05-06 23:11 ` Maciej W. Rozycki
2023-03-28 23:02 ` [PATCH 3/3] Adding more instructions to Allegrex CPU david
2023-05-06 23:11 ` Maciej W. Rozycki
2023-04-25 17:57 ` [PATCH 0/3] Add support for MIPS Allegrex David Guillen Fandos
2023-04-25 22:15 ` Maciej W. Rozycki
2023-05-06 8:03 ` David Guillen Fandos
2023-05-06 23:14 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2305062352510.54316@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=binutils@sourceware.org \
--cc=david@davidgf.net \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).