public inbox for
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <>
To: Ying Huang <>
Cc: libc-alpha <>,,
	 binutils <>
Subject: Re: [PATCH v7] MIPS: Sync elf.h from binutils
Date: Mon, 21 Aug 2023 12:14:47 +0100 (BST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, 21 Aug 2023, Ying Huang wrote:

> Can you help commit  these two patchs?

 To move forward you need to put the findings from the discussion in the 
change description, especially given the difficulty to figure out what the 
correct naming convention for the ELF file header flags is supposed to be.  
This is so that the next time this information is needed it is readily 
available rather than requiring chasing in the archives and/or depending 
on the presence of people who may still remember it as on this occasion.

 I think it will help if you split the glibc patch into self-contained 
functional subsets:

1. File header flags -- need documentation, as noted above.

2. SHT_MIPS_ABIFLAGS section type -- obviously correct, no need to
   elaborate on it.

3. Relocation types -- obviously correct, no need to elaborate on it.

4. GNU attribute stuff -- technically Tag_GNU_MIPS_ABI_FP along with the 
   enumeration it comes with is a bug fix for commit 0bd956720c45 ("Add 
   support for MIPS O32 FPXX and .MIPS.abiflags") which, conservatively, 
   only added definitions actually used by the dynamic loader itself, 
   despite that the header is a part of our public API for the MIPS psABI.  
   I think that either said definitions ought to have been provided 
   internally only or the whole of the API should have been exported at 
   once (this applies to #2 above too).

   Then the MSA stuff and Val_GNU_MIPS_ABI_FP_NAN2008 as later additions 
   are distinct changes each.  I think it is worth mentioning in the 
   inline comment that the latter attribute value has been superseded by 

   I'd be tempted to say these would best be three distint changes then, 
   but maybe other people would consider it overly pedantic.

 Then the binutils change needs to document the switch from E_* to EF_* 
definitions accordingly.


  reply	other threads:[~2023-08-21 11:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
     [not found] ` <>
     [not found]   ` <>
     [not found]     ` <>
     [not found]       ` <>
     [not found]         ` <>
     [not found]           ` <>
     [not found]             ` <>
2023-08-11 17:43               ` Maciej W. Rozycki
2023-08-16  6:15                 ` Ying Huang
2023-08-18 10:10                 ` 黄莺
2023-08-21  6:27                   ` Ying Huang
2023-08-21 11:14                     ` Maciej W. Rozycki [this message]
2023-08-22  8:55                       ` Ying Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).