* [PATCH] Add OpenBSD ARM Little Endian BFD support.
@ 2022-08-27 17:28 Frederic Cambus
2022-08-30 13:55 ` Richard Earnshaw
0 siblings, 1 reply; 6+ messages in thread
From: Frederic Cambus @ 2022-08-27 17:28 UTC (permalink / raw)
To: binutils
bfd/ChangeLog:
2022-08-27 Frederic Cambus <fred@statdns.com>
* config.bfd (arm-*-openbsd*): Add target.
---
bfd/config.bfd | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/bfd/config.bfd b/bfd/config.bfd
index 8c7be5da38a..0a47bf0484c 100644
--- a/bfd/config.bfd
+++ b/bfd/config.bfd
@@ -90,7 +90,6 @@ case $targ in
arm*-*-aout | \
arm-*-coff | \
arm*-*-netbsdaout* | \
- arm-*-openbsd* | \
arm-*-oabi | \
arm-*-riscix* | \
arm*-*-symbianelf* | \
@@ -387,6 +386,10 @@ case "${targ}" in
targ_defvec=arm_elf32_le_vec
targ_selvecs="arm_elf32_be_vec"
;;
+ arm-*-openbsd*)
+ targ_defvec=arm_elf32_le_vec
+ targ_selvecs="arm_elf32_be_vec"
+ ;;
arm-*-nto* | nto*arm*)
targ_defvec=arm_elf32_le_vec
targ_selvecs=arm_elf32_be_vec
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Add OpenBSD ARM Little Endian BFD support.
2022-08-27 17:28 [PATCH] Add OpenBSD ARM Little Endian BFD support Frederic Cambus
@ 2022-08-30 13:55 ` Richard Earnshaw
2022-08-31 22:12 ` Frederic Cambus
0 siblings, 1 reply; 6+ messages in thread
From: Richard Earnshaw @ 2022-08-30 13:55 UTC (permalink / raw)
To: Frederic Cambus, binutils
On 27/08/2022 18:28, Frederic Cambus wrote:
> bfd/ChangeLog:
>
> 2022-08-27 Frederic Cambus <fred@statdns.com>
>
> * config.bfd (arm-*-openbsd*): Add target.
> ---
> bfd/config.bfd | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/bfd/config.bfd b/bfd/config.bfd
> index 8c7be5da38a..0a47bf0484c 100644
> --- a/bfd/config.bfd
> +++ b/bfd/config.bfd
> @@ -90,7 +90,6 @@ case $targ in
> arm*-*-aout | \
> arm-*-coff | \
> arm*-*-netbsdaout* | \
> - arm-*-openbsd* | \
> arm-*-oabi | \
> arm-*-riscix* | \
> arm*-*-symbianelf* | \
> @@ -387,6 +386,10 @@ case "${targ}" in
> targ_defvec=arm_elf32_le_vec
> targ_selvecs="arm_elf32_be_vec"
> ;;
> + arm-*-openbsd*)
> + targ_defvec=arm_elf32_le_vec
> + targ_selvecs="arm_elf32_be_vec"
> + ;;
> arm-*-nto* | nto*arm*)
> targ_defvec=arm_elf32_le_vec
> targ_selvecs=arm_elf32_be_vec
>
This is exactly the same content as the entry directly above it
(netbsd), so please merge the two. It's a maintenance burden to have a
lot of duplicated entries.
R.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Add OpenBSD ARM Little Endian BFD support.
2022-08-30 13:55 ` Richard Earnshaw
@ 2022-08-31 22:12 ` Frederic Cambus
2022-09-01 9:43 ` Richard Earnshaw
0 siblings, 1 reply; 6+ messages in thread
From: Frederic Cambus @ 2022-08-31 22:12 UTC (permalink / raw)
To: binutils; +Cc: Richard Earnshaw
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Tue, Aug 30, 2022 at 02:55:00PM +0100, Richard Earnshaw wrote:
> On 27/08/2022 18:28, Frederic Cambus wrote:
> > + arm-*-openbsd*)
> > + targ_defvec=arm_elf32_le_vec
> > + targ_selvecs="arm_elf32_be_vec"
> > + ;;
>
> This is exactly the same content as the entry directly above it (netbsd), so
> please merge the two. It's a maintenance burden to have a lot of duplicated
> entries.
Makes sense, and note taken. Revised diff inline below, and full patch
attached for convenience.
diff --git a/bfd/config.bfd b/bfd/config.bfd
index 8c7be5da38a..a79a0e2bf5b 100644
--- a/bfd/config.bfd
+++ b/bfd/config.bfd
@@ -90,7 +90,6 @@ case $targ in
arm*-*-aout | \
arm-*-coff | \
arm*-*-netbsdaout* | \
- arm-*-openbsd* | \
arm-*-oabi | \
arm-*-riscix* | \
arm*-*-symbianelf* | \
@@ -383,7 +382,7 @@ case "${targ}" in
targ_defvec=arm_elf32_be_vec
targ_selvecs="arm_elf32_le_vec"
;;
- arm-*-netbsd*)
+ arm-*-netbsd* | arm-*-openbsd*)
targ_defvec=arm_elf32_le_vec
targ_selvecs="arm_elf32_be_vec"
;;
[-- Attachment #2: 0001-Add-OpenBSD-ARM-Little-Endian-BFD-support.patch --]
[-- Type: text/plain, Size: 947 bytes --]
From 076f37ac639b142cd4db2de835b047b57bb349e3 Mon Sep 17 00:00:00 2001
From: Frederic Cambus <fred@statdns.com>
Date: Wed, 31 Aug 2022 15:27:57 +0200
Subject: [PATCH] Add OpenBSD ARM Little Endian BFD support.
bfd/ChangeLog:
2022-08-31 Frederic Cambus <fred@statdns.com>
* config.bfd (arm-*-openbsd*): Add target.
---
bfd/config.bfd | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/bfd/config.bfd b/bfd/config.bfd
index 8c7be5da38a..a79a0e2bf5b 100644
--- a/bfd/config.bfd
+++ b/bfd/config.bfd
@@ -90,7 +90,6 @@ case $targ in
arm*-*-aout | \
arm-*-coff | \
arm*-*-netbsdaout* | \
- arm-*-openbsd* | \
arm-*-oabi | \
arm-*-riscix* | \
arm*-*-symbianelf* | \
@@ -383,7 +382,7 @@ case "${targ}" in
targ_defvec=arm_elf32_be_vec
targ_selvecs="arm_elf32_le_vec"
;;
- arm-*-netbsd*)
+ arm-*-netbsd* | arm-*-openbsd*)
targ_defvec=arm_elf32_le_vec
targ_selvecs="arm_elf32_be_vec"
;;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Add OpenBSD ARM Little Endian BFD support.
2022-08-31 22:12 ` Frederic Cambus
@ 2022-09-01 9:43 ` Richard Earnshaw
2022-09-01 15:56 ` Frederic Cambus
0 siblings, 1 reply; 6+ messages in thread
From: Richard Earnshaw @ 2022-09-01 9:43 UTC (permalink / raw)
To: Frederic Cambus, binutils
On 31/08/2022 23:12, Frederic Cambus wrote:
> On Tue, Aug 30, 2022 at 02:55:00PM +0100, Richard Earnshaw wrote:
>
>> On 27/08/2022 18:28, Frederic Cambus wrote:
>
>>> + arm-*-openbsd*)
>>> + targ_defvec=arm_elf32_le_vec
>>> + targ_selvecs="arm_elf32_be_vec"
>>> + ;;
>>
>> This is exactly the same content as the entry directly above it (netbsd), so
>> please merge the two. It's a maintenance burden to have a lot of duplicated
>> entries.
>
> Makes sense, and note taken. Revised diff inline below, and full patch
> attached for convenience.
Thanks, this is OK.
R.
>
> diff --git a/bfd/config.bfd b/bfd/config.bfd
> index 8c7be5da38a..a79a0e2bf5b 100644
> --- a/bfd/config.bfd
> +++ b/bfd/config.bfd
> @@ -90,7 +90,6 @@ case $targ in
> arm*-*-aout | \
> arm-*-coff | \
> arm*-*-netbsdaout* | \
> - arm-*-openbsd* | \
> arm-*-oabi | \
> arm-*-riscix* | \
> arm*-*-symbianelf* | \
> @@ -383,7 +382,7 @@ case "${targ}" in
> targ_defvec=arm_elf32_be_vec
> targ_selvecs="arm_elf32_le_vec"
> ;;
> - arm-*-netbsd*)
> + arm-*-netbsd* | arm-*-openbsd*)
> targ_defvec=arm_elf32_le_vec
> targ_selvecs="arm_elf32_be_vec"
> ;;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Add OpenBSD ARM Little Endian BFD support.
2022-09-01 9:43 ` Richard Earnshaw
@ 2022-09-01 15:56 ` Frederic Cambus
2022-09-02 10:31 ` Nick Clifton
0 siblings, 1 reply; 6+ messages in thread
From: Frederic Cambus @ 2022-09-01 15:56 UTC (permalink / raw)
To: Richard Earnshaw, binutils
On Thu, Sep 01, 2022 at 10:43:25AM +0100, Richard Earnshaw wrote:
> On 31/08/2022 23:12, Frederic Cambus wrote:
> > On Tue, Aug 30, 2022 at 02:55:00PM +0100, Richard Earnshaw wrote:
> >
> > > On 27/08/2022 18:28, Frederic Cambus wrote:
> >
> > > > + arm-*-openbsd*)
> > > > + targ_defvec=arm_elf32_le_vec
> > > > + targ_selvecs="arm_elf32_be_vec"
> > > > + ;;
> > >
> > > This is exactly the same content as the entry directly above it (netbsd), so
> > > please merge the two. It's a maintenance burden to have a lot of duplicated
> > > entries.
> >
> > Makes sense, and note taken. Revised diff inline below, and full patch
> > attached for convenience.
>
> Thanks, this is OK.
Thanks for the review.
I don't have commit access, could someone please commit it for me?
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-02 10:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-27 17:28 [PATCH] Add OpenBSD ARM Little Endian BFD support Frederic Cambus
2022-08-30 13:55 ` Richard Earnshaw
2022-08-31 22:12 ` Frederic Cambus
2022-09-01 9:43 ` Richard Earnshaw
2022-09-01 15:56 ` Frederic Cambus
2022-09-02 10:31 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).