From: Nick Clifton <nickc@redhat.com>
To: Indu Bhagat <indu.bhagat@oracle.com>, binutils@sourceware.org
Subject: Re: [PATCH,V3 09/13] gas: synthesize CFI for hand-written asm
Date: Wed, 13 Dec 2023 11:57:47 +0000 [thread overview]
Message-ID: <bed6b0eb-2bd3-488d-8937-733b08a80aec@redhat.com> (raw)
In-Reply-To: <20231211060359.3561062-10-indu.bhagat@oracle.com>
Hi Indu,
Minor hitch:
CC config/tc-i386.o
gas/config/tc-i386.c: In function 'i386_target_format':
gas/config/tc-i386.c:16302:25: error: 'x86_elf_abi' undeclared (first use in this function)
16302 | if (flag_synth_cfi && x86_elf_abi != X86_64_ABI)
| ^~~~~~~~~~~
make[3]: *** [Makefile:1470: config/tc-i386.o] Error 1
Which I am assuming comes from this frag:
> @@ -15334,6 +16297,9 @@ i386_target_format (void)
> else
> as_fatal (_("unknown architecture"));
>
> + if (flag_synth_cfi && x86_elf_abi != X86_64_ABI)
> + as_fatal (_("Synthesizing CFI is not supported for this ABI"));
> +
The trick is that I was testing with a toolchain configured as --target=x86_64-w64-mingw32
The same thing also happens with other x86 PE configurations, eg:
i686-pc-mingw32, x86_64-pc-mingw64, x86_64-pc-cygwin
The addition of a simple:
#if defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF)
[...]
#endif
around the offending fragment takes care of the problem, but I
thought that I would alert you to the issue so that you can do
your own checking and maybe choose a different solution if you
think that there is a better way to handle the situation.
Cheers
Nick
next prev parent reply other threads:[~2023-12-13 11:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 6:03 [PATCH,V3 00/13] Synthesize " Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 01/13] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 02/13] gas: dw2gencfi: use all_cfi_sections instead of cfi_sections Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 03/13] gas: dw2gencfi: expose a new cfi_set_last_fde API Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 04/13] gas: dw2gencfi: move some tc_* defines to the header file Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 05/13] gas: dw2gencfi: expose dot_cfi_sections for scfidw2gen Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 06/13] gas: dw2gencfi: externalize the all_cfi_sections Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 07/13] gas: add new command line option --scfi[=all,none] Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 08/13] gas: scfidw2gen: new functionality to prepare for SCFI Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 09/13] gas: synthesize CFI for hand-written asm Indu Bhagat
2023-12-13 11:57 ` Nick Clifton [this message]
2023-12-11 6:03 ` [PATCH,V3 10/13] gas: doc: update documentation for the new listing option Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 11/13] i386-reg.tbl: Add a comment to reflect dependency on ordering Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 12/13] gas: testsuite: add a x86_64 testsuite for SCFI Indu Bhagat
2023-12-11 6:03 ` [PATCH,V3 13/13] gas/NEWS: announce the new command line option Indu Bhagat
2023-12-15 9:13 ` [PATCH,V3 00/13] Synthesize CFI for hand-written asm Nick Clifton
2023-12-18 8:47 ` Jan Beulich
2023-12-19 21:02 ` Indu Bhagat
2023-12-20 7:51 ` Jan Beulich
2024-01-04 18:08 ` Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bed6b0eb-2bd3-488d-8937-733b08a80aec@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=indu.bhagat@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).