public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Nelson Chu <nelson@rivosinc.com>
Cc: Binutils <binutils@sourceware.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Andrew Waterman <andrew@sifive.com>,
	Jim Wilson <jim.wilson.gcc@gmail.com>
Subject: Re: [PATCH 2/2] RISC-V: adjust logic to avoid register name symbols
Date: Wed, 15 Feb 2023 10:21:18 +0100	[thread overview]
Message-ID: <c3df0014-7b23-df06-c321-1a16bd0e034b@suse.com> (raw)
In-Reply-To: <CAPpQWtBgBrjku9=kEHNND3H-E22wUBUedUj9FzJoGJBQRRpXTg@mail.gmail.com>

On 15.02.2023 09:48, Nelson Chu wrote:
> Thanks for the detailed clarify :-)
> 
> A quick update, I just use riscv-gnu-toolchain to build a linux toolchain with,
> gcc (releases/gcc-12.2.0) + binutils (master + these two patches) +
> glibc (release/2.37/master),
> and then I get some unexpected errors from gcc testsuite, which won't
> occurred without these patches.
> 
>                ========= Summary of gcc testsuite =========
>                             | # of unexpected case / # of unique unexpected case
>                             |          gcc |          g++ |     gfortran |
>      rv64gc/  lp64d/ medlow |  347 /    62 |   29 /     9 |    0 /     0 |
> 
> I haven't tested the elf regressions, and the whole linux regression,
> but it seems that there are some unexpected situations that we have
> not considered in this patch.

Hmm, this suggests to me that testcases are missing in the gas testsuite.

> Reproduce commands,
> 1. git clone https://github.com/riscv-collab/riscv-gnu-toolchain.git --recursive
> 2. need to install some tools before build,
> https://github.com/riscv-collab/riscv-gnu-toolchain#prerequisites
> 3. git checkout branches of gcc, binutils and glibc to the branches
> mentioned above
> 4. cd <patch-to-build-folder>
> 5. <patch-to-riscv-gnu-toolchain>configure
> --prefix=<patch-to-build-folder>build-install --with-arch=rv64gc
> 6. make report-gcc-linux -j32

Instead of me trying to go through this (at least part of which looks like
it won't really fit my normal environment; among other things I would also
prefer to work from upstream gcc, not any RISC-V clone thereof), could you
provide me with the detailed gcc.log and g++.log from the run (I know
they're huge, so you may want to upload them somewhere, or you might simply
extract relevant fragments)? Of course if it would be the complete logs,
then I would also need to know which, if any, FAILs are pre-existing.

From what you write it also doesn't look as if glibc was necessary to
include.

Jan

  reply	other threads:[~2023-02-15  9:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13  8:01 [PATCH 0/2] RISC-V/gas: re-work register named symbols avoidance logic Jan Beulich
2023-02-13  8:02 ` [PATCH 1/2] RISC-V: test for expected / no unexpected symbols Jan Beulich
2023-02-13  8:02 ` [PATCH 2/2] RISC-V: adjust logic to avoid register name symbols Jan Beulich
2023-02-15  3:09   ` Nelson Chu
2023-02-15  8:03     ` Jan Beulich
2023-02-15  8:48       ` Nelson Chu
2023-02-15  9:21         ` Jan Beulich [this message]
2023-02-16  9:36           ` Nelson Chu
2023-02-16 16:49             ` Jan Beulich
2023-02-16 16:54               ` Palmer Dabbelt
2023-03-03 13:52             ` Jan Beulich
2023-03-15 10:07               ` Nelson Chu
2023-03-15 11:49                 ` Jan Beulich
2023-03-16  0:30                   ` Nelson Chu
2023-04-19  9:37                     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3df0014-7b23-df06-c321-1a16bd0e034b@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew@sifive.com \
    --cc=binutils@sourceware.org \
    --cc=jim.wilson.gcc@gmail.com \
    --cc=nelson@rivosinc.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).