public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] CSKY: Set feature flags for default cpu.
@ 2020-09-13 12:48 Cooper Qu
  2020-09-14 12:31 ` Lifang Xia
  0 siblings, 1 reply; 2+ messages in thread
From: Cooper Qu @ 2020-09-13 12:48 UTC (permalink / raw)
  To: binutils, lifang_xia; +Cc: Cooper Qu

Fix floating point instructions not recognized when building GCC.

gas/
	PR 26608
	* config/tc-csky.c (md_begin): Set feature flags for default
	cpu.

---
 gas/config/tc-csky.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gas/config/tc-csky.c b/gas/config/tc-csky.c
index 3518b2a2fdb..808dca1e52c 100644
--- a/gas/config/tc-csky.c
+++ b/gas/config/tc-csky.c
@@ -1625,15 +1625,13 @@ md_begin (void)
   struct csky_macro_info const *macro;
   struct csky_arch_info const *p_arch;
   struct csky_cpu_info const *p_cpu;
-  int flags;
   other_flag = (do_opt_mmp | do_opt_mcp | do_opt_mcache
 		| do_opt_msecurity | do_opt_mhard_float);
   dsp_flag |= do_opt_mdsp | do_opt_medsp;
   isa_flag |= do_opt_mtrust | do_opt_mvdsp;
-  flags = other_flag;
 
   if (dsp_flag)
-    flags |= CSKY_ARCH_DSP;
+    other_flag |= CSKY_ARCH_DSP;
 
   if (mach_flag != 0)
     {
@@ -1654,6 +1652,7 @@ md_begin (void)
 #else
       parse_cpu ("ck810");
 #endif
+      mach_flag |= other_flag;
 #endif
     }
 
-- 
2.26.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] CSKY: Set feature flags for default cpu.
  2020-09-13 12:48 [PATCH] CSKY: Set feature flags for default cpu Cooper Qu
@ 2020-09-14 12:31 ` Lifang Xia
  0 siblings, 0 replies; 2+ messages in thread
From: Lifang Xia @ 2020-09-14 12:31 UTC (permalink / raw)
  To: Cooper Qu, binutils

Merged.
I add a comment in https://sourceware.org/bugzilla/show_bug.cgi?id=26608

Thanks

Lifang Xia

On 2020/9/13 20:48, Cooper Qu wrote:
> Fix floating point instructions not recognized when building GCC.
>
> gas/
> 	PR 26608
> 	* config/tc-csky.c (md_begin): Set feature flags for default
> 	cpu.
>
> ---
>   gas/config/tc-csky.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gas/config/tc-csky.c b/gas/config/tc-csky.c
> index 3518b2a2fdb..808dca1e52c 100644
> --- a/gas/config/tc-csky.c
> +++ b/gas/config/tc-csky.c
> @@ -1625,15 +1625,13 @@ md_begin (void)
>     struct csky_macro_info const *macro;
>     struct csky_arch_info const *p_arch;
>     struct csky_cpu_info const *p_cpu;
> -  int flags;
>     other_flag = (do_opt_mmp | do_opt_mcp | do_opt_mcache
>   		| do_opt_msecurity | do_opt_mhard_float);
>     dsp_flag |= do_opt_mdsp | do_opt_medsp;
>     isa_flag |= do_opt_mtrust | do_opt_mvdsp;
> -  flags = other_flag;
>   
>     if (dsp_flag)
> -    flags |= CSKY_ARCH_DSP;
> +    other_flag |= CSKY_ARCH_DSP;
>   
>     if (mach_flag != 0)
>       {
> @@ -1654,6 +1652,7 @@ md_begin (void)
>   #else
>         parse_cpu ("ck810");
>   #endif
> +      mach_flag |= other_flag;
>   #endif
>       }
>   

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-14 12:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-13 12:48 [PATCH] CSKY: Set feature flags for default cpu Cooper Qu
2020-09-14 12:31 ` Lifang Xia

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).