From: Mark Wielaard <mark@klomp.org>
To: buildbot@sourceware.org
Cc: Mark Wielaard <mark@klomp.org>
Subject: [PATCH] Add defaultWhenFalse=False to make_output_sync util.Property
Date: Sun, 15 Jan 2023 23:14:29 +0100 [thread overview]
Message-ID: <20230115221429.154033-1-mark@klomp.org> (raw)
The default value is used when the property doesn’t exist, or when
the value is something Python regards as False. And Python regards
the empty string as False. So add defaultWhenFalse=False to force
Buildbot to use the default argument only if the parameter is not
set.
---
builder/master.cfg | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/builder/master.cfg b/builder/master.cfg
index a887e88..d623924 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -968,7 +968,8 @@ getversion_step = steps.SetPropertyFromCommand(
# Allows a worker to override argument (with the empty string)
# if make doesn't support --output-sync=line
make_output_sync = util.Property('make_output_sync_arg',
- default='--output-sync=line')
+ default='--output-sync=line',
+ defaultWhenFalse=False)
make_step = steps.Compile(
command=["make", make_output_sync, util.Interpolate('-j%(prop:ncpus)s')],
name="make",
--
2.31.1
reply other threads:[~2023-01-15 22:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230115221429.154033-1-mark@klomp.org \
--to=mark@klomp.org \
--cc=buildbot@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).