public inbox for buildbot@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Sam James <sam@gentoo.org>
Cc: buildbot@sourceware.org
Subject: Re: [PATCH 2/2] gcc_full_build_factory: call contrib/test_summary after make check
Date: Tue, 31 Jan 2023 10:31:17 +0100	[thread overview]
Message-ID: <20230131093117.GH11361@gnu.wildebeest.org> (raw)
In-Reply-To: <20230131015611.1989999-2-sam@gentoo.org>

On Tue, Jan 31, 2023 at 01:56:11AM +0000, Sam James wrote:
> This gives us a nice summary of the various dejagnu results.

Looks like a nice idea in general.

But it also renames the *.sum files to .sum.sent, which means
they next bunsen step will fail to fetch them. You need to add
-t: prevents logs from being renamed

Also the "wrapper" text about emailing the sums is a little
odd imho. But it looks like there is no way to suppress that.

Cheers,

Mark

> ---
>  builder/master.cfg | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/builder/master.cfg b/builder/master.cfg
> index 71efbe9..562e794 100644
> --- a/builder/master.cfg
> +++ b/builder/master.cfg
> @@ -3259,6 +3259,13 @@ def gcc_full_build_factory_gen(extra_configure_arg=None):
>                  name='make check',
>                  timeout=3600,
>                  haltOnFailure=False, flunkOnFailure=True))
> +        # Get a useful summary (repeats the various dejagnu summaries) at
> +        # the end. From https://gcc.gnu.org/install/test.html.
> +        gcc_full_build_factory.addStep(steps.Test(
> +                workdir='gcc-build',
> +                command=['../gcc/contrib/test_summary'],
> +                name='contrib/test_summary',
> +                haltOnFailure=False, flunkOnFailure=True))
>          gcc_full_build_factory.addSteps(bunsen_logfile_upload_cpio_steps(
>                  ["*.log", "*.sum"],
>                  workdir='gcc-build'))
> -- 
> 2.39.1
> 

  reply	other threads:[~2023-01-31  9:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31  1:56 [PATCH 1/2] gcc_full_build_factory: pass '-k' to make check to maximise results Sam James
2023-01-31  1:56 ` [PATCH 2/2] gcc_full_build_factory: call contrib/test_summary after make check Sam James
2023-01-31  9:31   ` Mark Wielaard [this message]
2023-01-31 17:34     ` Sam James
2023-01-31  9:27 ` [PATCH 1/2] gcc_full_build_factory: pass '-k' to make check to maximise results Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230131093117.GH11361@gnu.wildebeest.org \
    --to=mark@klomp.org \
    --cc=buildbot@sourceware.org \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).