public inbox for buildbot@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: buildbot@sourceware.org
Subject: Re: Buildbot 'Blamelist' parsing (was: ☠ Buildbot (Sourceware): gccrust - failed configure (failure) (master))
Date: Sun, 12 Feb 2023 22:21:24 +0100	[thread overview]
Message-ID: <20230212212124.GA18077@gnu.wildebeest.org> (raw)
In-Reply-To: <877cwtelrq.fsf@euler.schwinge.homeip.net>

Hi Thomas,

On Tue, Feb 07, 2023 at 12:51:37PM +0100, Thomas Schwinge wrote:
> A thing I noticed by chance: "something" in the buildbot infrastructure
> seems to synthesize supposedly invalid <[...]@sourceware.org> addresses;
> for example, see the 'To:' of the parent (original) message:
> 
> > To: [...], Cui@sourceware.org, [...], Hu@sourceware.org, [...], bors@sourceware.org, [...]
> 
> I'm reasonably sure that at least <bors@sourceware.org> doesn't exist.
> ;-)
> 
> I suppose those recipients are generated out of the 'Blamelist':
> 
> On 2023-02-02T22:47:35+0000, builder@sourceware.org wrote:
> > Blamelist: [...], Cui,Lili <lili.cui@intel.com>, [...], Hu, Lin1 <lin1.hu@intel.com>, [...], bors[bot] <26634292+bors[bot]@users.noreply.github.com>, [...]
> 
> Is there something going wrong with (missing) quoting, "special"
> characters like ',' or '[' etc. in the 'display-name'?

We don't have a specific "lookup" function for the MailNotifier.  So
the "interested users" are just the git Authors.  Normally the Author
is a proper name <email>. Then things are fine.  Part of the issue is
that github apparently doesn't require/set a proper Name <email>, but
allows ids like those bors. The other thing you noticed is that ther
are commits where the Author is set to "Cui,Lili
<lili.cui@intel.com>". This apparently results in two users/addresses
Cui <without-email> and Lili <with-email>.

It might be possible to write a email verifier/checker by adding a
lookup function for the MailNotifier. See
https://buildbot.readthedocs.io/en/stable/manual/configuration/reporters/mail_notifier.html

Cheers,

Mark

      reply	other threads:[~2023-02-12 21:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230202224735.6E8B93858C53@sourceware.org>
2023-02-07 11:43 ` Thomas Schwinge
2023-02-07 11:51 ` Thomas Schwinge
2023-02-12 21:21   ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230212212124.GA18077@gnu.wildebeest.org \
    --to=mark@klomp.org \
    --cc=buildbot@sourceware.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).