Buildbot 'Blamelist' parsing (was: ☠ Buildbot (Sourceware): gccrust - failed configure (failure) (master))

Buildbot 'Blamelist' parsing (was: ☠ Buildbot (Sourceware): gccrust - failed configure (failure) (master))

[Thomas Schwinge]

Hi Mark and team!

A thing I noticed by chance: "something" in the buildbot infrastructure
seems to synthesize supposedly invalid <[...]@sourceware.org> addresses;
for example, see the 'To:' of the parent (original) message:

> To: [...], Cui@sourceware.org, [...], Hu@sourceware.org, [...], bors@sourceware.org, [...]

I'm reasonably sure that at least <bors@sourceware.org> doesn't exist.
;-)

I suppose those recipients are generated out of the 'Blamelist':

On 2023-02-02T22:47:35+0000, builder@sourceware.org wrote:
> Blamelist: [...], Cui,Lili <lili.cui@intel.com>, [...], Hu, Lin1 <lin1.hu@intel.com>, [...], bors[bot] <26634292+bors[bot]@users.noreply.github.com>, [...]

Is there something going wrong with (missing) quoting, "special"
characters like ',' or '[' etc. in the 'display-name'?


Grüße
 Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

Buildbot 'Blamelist' parsing (was: ☠ Buildbot (Sourceware): gccrust - failed configure (failure) (master))

[Thomas Schwinge]

[re-send to <buildbot@sourceware.org> instead of <builder@sourceware.org>]


Hi Mark and team!

A thing I noticed by chance: "something" in the buildbot infrastructure
seems to synthesize supposedly invalid <[...]@sourceware.org> addresses;
for example, see the 'To:' of the parent (original) message:

> To: [...], Cui@sourceware.org, [...], Hu@sourceware.org, [...], bors@sourceware.org, [...]

I'm reasonably sure that at least <bors@sourceware.org> doesn't exist.
;-)

I suppose those recipients are generated out of the 'Blamelist':

On 2023-02-02T22:47:35+0000, builder@sourceware.org wrote:
> Blamelist: [...], Cui,Lili <lili.cui@intel.com>, [...], Hu, Lin1 <lin1.hu@intel.com>, [...], bors[bot] <26634292+bors[bot]@users.noreply.github.com>, [...]

Is there something going wrong with (missing) quoting, "special"
characters like ',' or '[' etc. in the 'display-name'?


Grüße
 Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

Re: Buildbot 'Blamelist' parsing (was: ☠ Buildbot (Sourceware): gccrust - failed configure (failure) (master))

[Mark Wielaard]

Hi Thomas,

On Tue, Feb 07, 2023 at 12:51:37PM +0100, Thomas Schwinge wrote:
> A thing I noticed by chance: "something" in the buildbot infrastructure
> seems to synthesize supposedly invalid <[...]@sourceware.org> addresses;
> for example, see the 'To:' of the parent (original) message:
> 
> > To: [...], Cui@sourceware.org, [...], Hu@sourceware.org, [...], bors@sourceware.org, [...]
> 
> I'm reasonably sure that at least <bors@sourceware.org> doesn't exist.
> ;-)
> 
> I suppose those recipients are generated out of the 'Blamelist':
> 
> On 2023-02-02T22:47:35+0000, builder@sourceware.org wrote:
> > Blamelist: [...], Cui,Lili <lili.cui@intel.com>, [...], Hu, Lin1 <lin1.hu@intel.com>, [...], bors[bot] <26634292+bors[bot]@users.noreply.github.com>, [...]
> 
> Is there something going wrong with (missing) quoting, "special"
> characters like ',' or '[' etc. in the 'display-name'?

We don't have a specific "lookup" function for the MailNotifier.  So
the "interested users" are just the git Authors.  Normally the Author
is a proper name <email>. Then things are fine.  Part of the issue is
that github apparently doesn't require/set a proper Name <email>, but
allows ids like those bors. The other thing you noticed is that ther
are commits where the Author is set to "Cui,Lili
<lili.cui@intel.com>". This apparently results in two users/addresses
Cui <without-email> and Lili <with-email>.

It might be possible to write a email verifier/checker by adding a
lookup function for the MailNotifier. See
https://buildbot.readthedocs.io/en/stable/manual/configuration/reporters/mail_notifier.html

Cheers,

Mark