Re: ☝ Buildbot (Sourceware): binutils-gdb - retry lost connection test (retry) (master)

[Mark Wielaard <mark@klomp.org>]

Hi Sam,

On Fri, Sep 01, 2023 at 12:25:26PM +0100, Sam James wrote:
> 
> builder--- via Binutils <binutils@sourceware.org> writes:
> 
> > A retry build has been detected on builder binutils-gentoo-sparc while building binutils-gdb.
> 
> I just rebooted him, so this is fine.
> 
> Can we disable these announcements for retries?

We have the following two notifiers for binutils:

  # Problem report for the whole binutils tagged builder set
  generator_binutils = reporters.BuildSetStatusGenerator(
          mode=('problem',), tags=['binutils'])
  mn_binutils = reporters.MailNotifier(
          fromaddr="builder@sourceware.org",
          sendToInterestedUsers=True,
          generators=[generator_binutils])
  c['services'].append(mn_binutils)

  # Change report for the whole binutils tagged builder set
  generator_binutils_change = reporters.BuildSetStatusGenerator(
          mode=('change',), tags=['binutils'])
  mn_binutils_change = reporters.MailNotifier(
          fromaddr="builder@sourceware.org",
          sendToInterestedUsers=False,
          extraRecipients=['binutils@sourceware.org'],
          generators=[generator_binutils_change])
  c['services'].append(mn_binutils_change)

The first sents email to the patch author(s). The second to binutils
mailinglist. The first for mode=('problem',) in the whole buildset,
the second for mode=('change',) also in the whole buildset.

https://docs.buildbot.net/current/manual/configuration/report_generators/buildset.html#buildsetstatusgenerator

'problem' Include a build which failed when the previous build has
passed.

'change' Include builds which change status.

So the first seems fine. But 'change' isn't really what we want.  It
would be nice to have something like 'problem', '!problem', so you get
builds that failed when the previous build has passed and builds that
passed when the previous builds failed. But 'change' contains all
transformations.

Should we change the second to mode=('problem',) too?  You would only
get a report of there was a new failure, not when the problem has been
resolved.

And if we do, maybe change the forst from 'problem' to 'change'? So
patch authors get a notice about any change in the buildset (probably)
caused by their patch?

Cheers,

Mark