From: Mark Wielaard <mark@klomp.org>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: "Arsen Arsenović" <arsen@aarsen.me>, buildbot@sourceware.org
Subject: Re: [PATCH 2/8] autoregen.py: fix a pyright `reportConstantRedefinition` warning
Date: Wed, 13 Mar 2024 09:58:34 +0100 [thread overview]
Message-ID: <20240313085834.GO30331@gnu.wildebeest.org> (raw)
In-Reply-To: <75976ed0-ecfc-4abc-9ce7-3188059d4169@efficios.com>
Hi,
On Tue, Mar 12, 2024 at 12:00:30PM -0400, Simon Marchi wrote:
> On 3/12/24 07:39, Arsen Arsenović wrote:
> > Though, if I am correct, we could also just use subprocess.runs env=
> > parameter to put up a modified env.
>
> Yeah that makes more sense. See patch below that implements this.
Looks good.
Applied,
Mark
next prev parent reply other threads:[~2024-03-13 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 19:01 [PATCH 0/8] Some changes to autoregen.py Simon Marchi
2024-03-11 19:01 ` [PATCH 1/8] autoregen.py: re-format with black 24.2.0 Simon Marchi
2024-03-11 19:01 ` [PATCH 2/8] autoregen.py: fix a pyright `reportConstantRedefinition` warning Simon Marchi
[not found] ` <871q8f7jx5.fsf@aarsen.me>
2024-03-12 16:00 ` Simon Marchi
2024-03-13 8:58 ` Mark Wielaard [this message]
2024-03-18 17:36 ` Arsen Arsenović
2024-03-11 19:01 ` [PATCH 3/8] autoregen.py: add type annotation for config_folders Simon Marchi
2024-03-11 19:01 ` [PATCH 4/8] autoregen.py: capitalize some constant names Simon Marchi
2024-03-11 19:01 ` [PATCH 5/8] autoregen.py: add non-suffixed version of the tools Simon Marchi
2024-03-11 19:01 ` [PATCH 6/8] autoregen.py: print executed commands on stdout Simon Marchi
2024-03-11 19:01 ` [PATCH 7/8] autoregen.py: let subprocesses print to stdout/stderr Simon Marchi
[not found] ` <87plvz7k10.fsf@aarsen.me>
2024-03-12 15:40 ` Simon Marchi
2024-03-13 8:46 ` Mark Wielaard
2024-03-11 19:01 ` [PATCH 8/8] autoregen.py: be more verbose Simon Marchi
2024-03-11 21:04 ` [PATCH 0/8] Some changes to autoregen.py Sam James
2024-03-11 21:52 ` Mark Wielaard
2024-03-12 1:53 ` Simon Marchi
2024-03-12 10:17 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240313085834.GO30331@gnu.wildebeest.org \
--to=mark@klomp.org \
--cc=arsen@aarsen.me \
--cc=buildbot@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).