Re: [PATCH] autoregen.py: use autoreconf in some directories

[Mark Wielaard <mark@klomp.org>]

Hi Simon,

On Tue, Mar 12, 2024 at 01:53:37PM -0400, Simon Marchi wrote:
> The builder currently mis-generates the config files for the gdb and
> gnulib directories.  It passes `-I ../config` to aclocal, causing the
> include path order to be different to what it would be without that -I
> argument, causing the generated aclocal.m4 to be different (same entries
> but different order).
> 
> For the gdb, gdbserver, gdbsupport and gnulib directories, the config
> files are usually re-generated without any -I argument.  In fact, for
> gnulib, it is baked in gnulib/update-gnulib.sh that aclocal should be
> called without -I arguments:
> 
>     aclocal &&
>     autoconf &&
>     autoheader &&
>     automake
> 
> Moreover, they can be re-generated using autoreconf, removing the need
> to guess which speicific tools need to be invoked.  autoreconf takes a
> bit more time to run than the individual tools, but it's worth it for
> the simplicity.
> 
> So, add a list of directories for which it is known that they can be
> re-generated using a simple autoreconf without special flags.  For these
> directories, call `autoreconf -f`.

Very nice, now running this regenerates the binutils-gdb files exactly
as they are checked in. Also tested on the gcc tree, which also works
fine.

Applied (with small adjustments for the previous two patches).

Thanks,

Mark