From: "Frank Ch. Eigler" <fche@elastic.org>
To: buildbot@sourceware.org
Subject: patch: use "make -k check" broadly
Date: Wed, 6 Mar 2024 12:14:31 -0500 [thread overview]
Message-ID: <Zeikd5d__5viy-sG@elastic.org> (raw)
Hi -
The following diff gets the annobin and a few other package
make_check* steps to use "make -k check" rather than "make check", so
that early partial failures do not doom the entire run. Many other
package builders already use the equivalent.
diff --git a/builder/master.cfg b/builder/master.cfg
index e4cd0802a051..d0b046f7af19 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -1194,26 +1194,26 @@ make_pdf_step = steps.Compile(
command=["make", "pdf"],
name="make pdf")
make_check_step = steps.Test(
- command=addOutputSync.withArgs(["make", "check",
+ command=addOutputSync.withArgs(["make", "-k", "check",
util.Interpolate('-j%(prop:ncpus)s')]),
name="make check", haltOnFailure=False, flunkOnFailure=True)
# make check explicitly not using -j
make_single_check_step = steps.Test(
- command=["make", "check"],
+ command=["make", "-k", "check"],
name="make check")
make_single_test_suite_step = steps.Test(
- command=["make", "check"],
+ command=["make", "-k" "check"],
name="make check",
logfiles={"test-suite.log": "tests/test-suite.log"})
# Same as make_check_step but with tests/test-suite.log recorded
make_check_test_suite_step = steps.Test(
- command=addOutputSync.withArgs(["make", "check",
+ command=addOutputSync.withArgs(["make", "-k", "check",
util.Interpolate('-j%(prop:ncpus)s')]),
name="make check", haltOnFailure=False, flunkOnFailure=True,
logfiles={"test-suite.log": "tests/test-suite.log"})
# Same but with tests/testsuite.log (note, no dash)
make_check_testsuite_step = steps.Test(
- command=addOutputSync.withArgs(["make", "check",
+ command=addOutputSync.withArgs(["make", "-k", "check",
util.Interpolate('-j%(prop:ncpus)s')]),
name="make check", haltOnFailure=False, flunkOnFailure=True,
logfiles={"testsuite.log": "tests/testsuite.log"})
- FChE
next reply other threads:[~2024-03-06 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 17:14 Frank Ch. Eigler [this message]
2024-03-06 22:21 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zeikd5d__5viy-sG@elastic.org \
--to=fche@elastic.org \
--cc=buildbot@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).