public inbox for bunsen@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Serhei Makarov <me@serhei.io>
Cc: Bunsen <bunsen@sourceware.org>
Subject: Re: [PATCH v2] Introduce simplified grok_architecture function
Date: Wed, 23 Sep 2020 12:46:03 -0700	[thread overview]
Message-ID: <d50a58b0-32f9-881f-18c2-6b4a45f4079c@redhat.com> (raw)
In-Reply-To: <6e7c5822-19a1-4a36-a88e-ba3a99b3af4d@www.fastmail.com>

On 9/23/20 12:26 PM, Serhei Makarov wrote:
>> -    native_configuration_is = None
>> +    testrun.arch = None
> <snip>
>> +        if testrun.arch is None and line.startswith("Native 
>> configuration is"):
>> +            testrun.arch = grok_architecture(line)

> I would set uname_machine at this point and keep the 'testrun.arch =
> uname_machine' assignment in the block at the bottom.

I've reverted those hunks (more or less) to maintain that style 
and pushed the resulting patch.

Thanks!

Keith


  reply	other threads:[~2020-09-23 19:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 13:21 Fwd: Re: [PATCH] " Serhei Makarov
2020-09-23 18:14 ` Keith Seitz
2020-09-23 19:15   ` [PATCH v2] " Keith Seitz
2020-09-23 19:26     ` Serhei Makarov
2020-09-23 19:46       ` Keith Seitz [this message]
2020-09-23 22:48         ` Serhei Makarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d50a58b0-32f9-881f-18c2-6b4a45f4079c@redhat.com \
    --to=keiths@redhat.com \
    --cc=bunsen@sourceware.org \
    --cc=me@serhei.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).