public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
* remove dups from cgen/cpu?
@ 2009-07-09 16:09 Doug Evans
  2009-07-09 17:03 ` Dave Brolley
  2009-07-24 17:53 ` Dave Korn
  0 siblings, 2 replies; 4+ messages in thread
From: Doug Evans @ 2009-07-09 16:09 UTC (permalink / raw)
  To: fche, cgen

Hi.

I think it's time to remove the duplicates in src/cgen/cpu
and keep just the copies in src/cpu.

Any objections?

[Are there any that Redhat wants to keep in src/cgen/cpu,
at least for now?]

[Some files, e.g. sh*, have signficant differences.
I was going to leave resolving those for another pass,
and just do the ones with no or simple differences first.]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: remove dups from cgen/cpu?
  2009-07-09 16:09 remove dups from cgen/cpu? Doug Evans
@ 2009-07-09 17:03 ` Dave Brolley
  2009-07-12 16:07   ` Doug Evans
  2009-07-24 17:53 ` Dave Korn
  1 sibling, 1 reply; 4+ messages in thread
From: Dave Brolley @ 2009-07-09 17:03 UTC (permalink / raw)
  To: Doug Evans; +Cc: fche, cgen

Doug Evans wrote:
> Hi.
>
> I think it's time to remove the duplicates in src/cgen/cpu
> and keep just the copies in src/cpu.
>
> Any objections?
>
> [Are there any that Redhat wants to keep in src/cgen/cpu,
> at least for now?]
>   
I have no objections to the removal of duplicates. Although it has been 
explained to me several times, I keep forgetting why we needed src/cpu 
vs src/cgen/cpu at all.
> [Some files, e.g. sh*, have signficant differences.
> I was going to leave resolving those for another pass,
> and just do the ones with no or simple differences first.]
>   
Wrt sh, the work in src/cpu is most up to date.

Dave

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: remove dups from cgen/cpu?
  2009-07-09 17:03 ` Dave Brolley
@ 2009-07-12 16:07   ` Doug Evans
  0 siblings, 0 replies; 4+ messages in thread
From: Doug Evans @ 2009-07-12 16:07 UTC (permalink / raw)
  To: Dave Brolley; +Cc: fche, cgen

Dave Brolley wrote:
> I have no objections to the removal of duplicates. Although it has 
> been explained to me several times, I keep forgetting why we needed 
> src/cpu vs src/cgen/cpu at all.

They're source code that go into building the programs and we don't ship 
src/cgen with binutils, et.al.

>> [Some files, e.g. sh*, have signficant differences.
>> I was going to leave resolving those for another pass,
>> and just do the ones with no or simple differences first.]
>>   
> Wrt sh, the work in src/cpu is most up to date.

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: remove dups from cgen/cpu?
  2009-07-09 16:09 remove dups from cgen/cpu? Doug Evans
  2009-07-09 17:03 ` Dave Brolley
@ 2009-07-24 17:53 ` Dave Korn
  1 sibling, 0 replies; 4+ messages in thread
From: Dave Korn @ 2009-07-24 17:53 UTC (permalink / raw)
  To: Doug Evans; +Cc: fche, cgen

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Doug Evans wrote:
> Hi.
> 
> I think it's time to remove the duplicates in src/cgen/cpu
> and keep just the copies in src/cpu.
> 
> Any objections?

  None here, but how about doing this while we're at it?

cgen/ChangeLog:

	* Makefile.am (ARCHFILE): Search both cpu/ subdirs, with priority
	to top-level cpu/ over cgen/cpu/.
	* Makefile.in: Regenerate.

    cheers,
      DaveK

[-- Attachment #2: cgen-which-cpu-dir.diff --]
[-- Type: text/x-c, Size: 669 bytes --]

Index: cgen/Makefile.am
===================================================================
RCS file: /cvs/src/src/cgen/Makefile.am,v
retrieving revision 1.8
diff -p -u -r1.8 Makefile.am
--- cgen/Makefile.am	13 Jul 2009 20:55:21 -0000	1.8
+++ cgen/Makefile.am	24 Jul 2009 17:46:39 -0000
@@ -7,7 +7,7 @@ SUBDIRS = doc testsuite
 GUILE = "`if test -f ../guile/libguile/guile ; then echo ../guile/libguile/guile; else echo guile ; fi`" -l $(srcdir)/guile.scm -s
 CGENFLAGS = -v
 ARCH = @arch@
-ARCHFILE = $(srcroot)/cpu/$(ARCH).cpu
+ARCHFILE = $(firstword $(wildcard $(srcroot)/cpu/$(ARCH).cpu $(srcroot)/cgen/cpu/$(ARCH).cpu))
 
 # for various utility rules
 MACHS = all

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-07-24 17:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-09 16:09 remove dups from cgen/cpu? Doug Evans
2009-07-09 17:03 ` Dave Brolley
2009-07-12 16:07   ` Doug Evans
2009-07-24 17:53 ` Dave Korn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).