public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
* cluster/gfs-kernel/src/gfs glock.c
@ 2008-01-24 20:42 bmarzins
0 siblings, 0 replies; 22+ messages in thread
From: bmarzins @ 2008-01-24 20:42 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: bmarzins@sourceware.org 2008-01-24 20:42:01
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Fix for bz #426291. gfs_glock_dq was traversing the gl_holders list without
holding the gl_spin spinlock, this was causing a problem when the list item
it was currently looking at got removed from the list. The solution is to
not traverse the list, because it is unncessary. Unfortunately, there is also
a bug in this section of code, where you can't guarantee that you will not
cache a glock held with GL_NOCACHE. Fixing this issue requires significantly
more work.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&r1=1.35&r2=1.36
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2008-01-29 22:21 bmarzins
0 siblings, 0 replies; 22+ messages in thread
From: bmarzins @ 2008-01-29 22:21 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: bmarzins@sourceware.org 2008-01-29 22:21:45
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Fix for bz #419391. gfs_glock_dq was traversing the gl_holders list without
holding the gl_spin spinlock, this was causing a problem when the list item
it was currently looking at got removed from the list. The solution is to
not traverse the list, because it is unncessary. Unfortunately, there is also
a bug in this section of code, where you can't guarantee that you will not
cache a glock held with GL_NOCACHE. Fixing this issue requires significantly
more work.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.20.2.6&r2=1.20.2.7
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2008-01-28 6:40 fabbione
0 siblings, 0 replies; 22+ messages in thread
From: fabbione @ 2008-01-28 6:40 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: fabbione@sourceware.org 2008-01-28 06:40:25
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Remove unused variable
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&r1=1.36&r2=1.37
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2008-01-24 22:23 bmarzins
0 siblings, 0 replies; 22+ messages in thread
From: bmarzins @ 2008-01-24 22:23 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL51
Changes by: bmarzins@sourceware.org 2008-01-24 22:23:47
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Oops. Reverted fix for bz #426291. It isn't going into RHEL 5.1
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL51&r1=1.29.2.5.2.1&r2=1.29.2.5.2.2
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2008-01-24 20:25 bmarzins
0 siblings, 0 replies; 22+ messages in thread
From: bmarzins @ 2008-01-24 20:25 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: bmarzins@sourceware.org 2008-01-24 20:25:10
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Fix for bz #426291. gfs_glock_dq was traversing the gl_holders list without
holding the gl_spin spinlock, this was causing a problem when the list item
it was currently looking at got removed from the list. The solution is to
not traverse the list, because it is unncessary. Unfortunately, there is also
a bug in this section of code, where you can't guarantee that you will not
cache a glock held with GL_NOCACHE. Fixing this issue requires significantly
more work.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.29.2.5&r2=1.29.2.6
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2008-01-24 20:08 bmarzins
0 siblings, 0 replies; 22+ messages in thread
From: bmarzins @ 2008-01-24 20:08 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL51
Changes by: bmarzins@sourceware.org 2008-01-24 20:08:43
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Fix for bz #426291. gfs_glock_dq was traversing the gl_holders list without
holding the gl_spin spinlock, this was causing a problem when the list item
it was currently looking at got removed from the list. The solution is to
not traverse the list, because it is unncessary. Unfortunately, there is also
a bug in this section of code, where you can't guarantee that you will not
cache a glock held with GL_NOCACHE. Fixing this issue requires significantly
more work.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL51&r1=1.29.2.5&r2=1.29.2.5.2.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2007-06-26 20:39 wcheng
0 siblings, 0 replies; 22+ messages in thread
From: wcheng @ 2007-06-26 20:39 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL45
Changes by: wcheng@sourceware.org 2007-06-26 20:39:25
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Bugzilla 245776:
Previous CVS check-in did a last minute change with the way purge count
was calculated. The intention was to trim glocks evenly across all the
hash buckets and apparently the size of hash array was overlooked. It
ends up with zero trimming count most of the time. Fix this oversight.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL45&r1=1.20.2.5&r2=1.20.2.5.2.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2007-06-26 20:34 wcheng
0 siblings, 0 replies; 22+ messages in thread
From: wcheng @ 2007-06-26 20:34 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: wcheng@sourceware.org 2007-06-26 20:34:16
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Bugzilla 245776:
Previous CVS check-in did a last minute change with the way purge count
was calculated. The intention was to trim glocks evenly across all the
hash buckets and apparently the size of hash array was overlooked. It
ends up with zero trimming count most of the time. Fix this oversight.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.20.2.5&r2=1.20.2.6
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2007-06-26 19:44 wcheng
0 siblings, 0 replies; 22+ messages in thread
From: wcheng @ 2007-06-26 19:44 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: wcheng@sourceware.org 2007-06-26 19:43:59
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Bugzilla 239729:
The purge_nr in glock_scan is already a pointer. Fix error in today's check-in.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&r1=1.34&r2=1.35
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2007-06-26 19:42 wcheng
0 siblings, 0 replies; 22+ messages in thread
From: wcheng @ 2007-06-26 19:42 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: wcheng@sourceware.org 2007-06-26 19:42:32
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Bugzilla 239729
The purge_nr is already a pointer - another mistake in today's check-in.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.29.2.4&r2=1.29.2.5
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2007-06-26 18:38 wcheng
0 siblings, 0 replies; 22+ messages in thread
From: wcheng @ 2007-06-26 18:38 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: wcheng@sourceware.org 2007-06-26 18:38:01
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Bugzilla 239729:
Accidentally moved the wrong patch - fix previous check-in.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&r1=1.33&r2=1.34
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2007-06-26 18:30 wcheng
0 siblings, 0 replies; 22+ messages in thread
From: wcheng @ 2007-06-26 18:30 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: wcheng@sourceware.org 2007-06-26 18:30:01
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Bugzilla 239729:
Hit the mouse too soon before commit ... Hopefully this time it is all
correct.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.29.2.3&r2=1.29.2.4
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2007-06-26 17:50 wcheng
0 siblings, 0 replies; 22+ messages in thread
From: wcheng @ 2007-06-26 17:50 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: wcheng@sourceware.org 2007-06-26 17:50:06
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
RedHat bugzilla 239727:
Previous CVS check-in did a last minute change with the way purge count
was calculated. The intention was to trim glocks evenly across all the
hash buckets and apparently the size of hash array was overlooked. It
ends up with zero trimming count most of the time. This virtually makes
glock trimming patch a void feature.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&r1=1.32&r2=1.33
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2007-06-26 17:38 wcheng
0 siblings, 0 replies; 22+ messages in thread
From: wcheng @ 2007-06-26 17:38 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: wcheng@sourceware.org 2007-06-26 17:38:07
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Bugzilla 239729:
Previous CVS check-in did a last minute change with the way purge count
was calculated in glock trimming patch. The intention was to trim glocks
evenly across all the hash buckets and apparently the size of hash array
was overlooked. It ends up with zero trimming count most of the time.
This virtually makes glock trimming patch a void feature.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.29.2.2&r2=1.29.2.3
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2007-01-25 22:38 wcheng
0 siblings, 0 replies; 22+ messages in thread
From: wcheng @ 2007-01-25 22:38 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: wcheng@sourceware.org 2007-01-25 22:38:39
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
Bugzilla 214239 - trimming glock
Forgot to increase gl_count in previous check-in.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.20.2.4&r2=1.20.2.5
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2006-05-17 15:28 adas
0 siblings, 0 replies; 22+ messages in thread
From: adas @ 2006-05-17 15:28 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: STABLE
Changes by: adas@sourceware.org 2006-05-17 15:28:24
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
bz 191222 : removed debug printk
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=STABLE&r1=1.20.2.1.4.1.2.1&r2=1.20.2.1.4.1.2.2
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2006-05-17 15:27 adas
0 siblings, 0 replies; 22+ messages in thread
From: adas @ 2006-05-17 15:27 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: adas@sourceware.org 2006-05-17 15:27:21
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
bz 191222 : removed debug printk
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&r1=1.25&r2=1.26
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2006-05-17 15:26 adas
0 siblings, 0 replies; 22+ messages in thread
From: adas @ 2006-05-17 15:26 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: adas@sourceware.org 2006-05-17 15:26:03
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
bz 191222 : removed debug printk
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.20.2.2&r2=1.20.2.3
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2006-05-15 23:07 adas
0 siblings, 0 replies; 22+ messages in thread
From: adas @ 2006-05-15 23:07 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: adas@sourceware.org 2006-05-15 23:07:35
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
bz191222 fix. When releasing a glock with GL_NOCACHE flag set, care was not taken to ensure that only one holder for the glock remained. This was corrupting the glock and preventing further access to the glock. FLOCKS use this GL_NOCACHE flag. See bugzilla for more information. This patch needs to go through a test cycle to ensure that it doesn't affect other code
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&r1=1.24&r2=1.25
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2006-05-15 23:01 adas
0 siblings, 0 replies; 22+ messages in thread
From: adas @ 2006-05-15 23:01 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: STABLE
Changes by: adas@sourceware.org 2006-05-15 23:01:03
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
bz191222 fix. When releasing a glock with GL_NOCACHE flag set, care was not taken to ensure that only one holder for the glock remained. This was corrupting the glock and preventing further access to the glock. FLOCKS use this GL_NOCACHE flag. See bugzilla for more information. This patch needs to go through a test cycle to ensure that it doesn't affect other code
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=STABLE&r1=1.20.2.1.4.1&r2=1.20.2.1.4.1.2.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2006-05-15 22:58 adas
0 siblings, 0 replies; 22+ messages in thread
From: adas @ 2006-05-15 22:58 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: adas@sourceware.org 2006-05-15 22:58:53
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
bz191222 fix. When releasing a glock with GL_NOCACHE flag set, care was not taken to ensure that only one holder for the glock remained. This was corrupting the glock and preventing further access to the glock. FLOCKS use this GL_NOCACHE flag. See bugzilla for more information. This patch needs to go through a test cycle to ensure that it doesn't affect other code
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.20.2.1&r2=1.20.2.2
^ permalink raw reply [flat|nested] 22+ messages in thread
* cluster/gfs-kernel/src/gfs glock.c
@ 2005-10-06 22:32 teigland
0 siblings, 0 replies; 22+ messages in thread
From: teigland @ 2005-10-06 22:32 UTC (permalink / raw)
To: cluster-cvs
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: teigland@sourceware.org 2005-10-06 22:32:01
Modified files:
gfs-kernel/src/gfs: glock.c
Log message:
withdraw if the lock module returns LM_OUT_ERROR
Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&r1=1.22&r2=1.23
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2008-01-29 22:21 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-24 20:42 cluster/gfs-kernel/src/gfs glock.c bmarzins
-- strict thread matches above, loose matches on Subject: below --
2008-01-29 22:21 bmarzins
2008-01-28 6:40 fabbione
2008-01-24 22:23 bmarzins
2008-01-24 20:25 bmarzins
2008-01-24 20:08 bmarzins
2007-06-26 20:39 wcheng
2007-06-26 20:34 wcheng
2007-06-26 19:44 wcheng
2007-06-26 19:42 wcheng
2007-06-26 18:38 wcheng
2007-06-26 18:30 wcheng
2007-06-26 17:50 wcheng
2007-06-26 17:38 wcheng
2007-01-25 22:38 wcheng
2006-05-17 15:28 adas
2006-05-17 15:27 adas
2006-05-17 15:26 adas
2006-05-15 23:07 adas
2006-05-15 23:01 adas
2006-05-15 22:58 adas
2005-10-06 22:32 teigland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).