From: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
To: crossgcc@sourceware.org
Cc: Zhenqiang Chen <zhenqiang.chen@linaro.org>
Subject: Re: [nls PATCH 3 of 3] cc/gcc: Handle --disable-nls config
Date: Tue, 22 Nov 2011 17:26:00 -0000 [thread overview]
Message-ID: <201111221826.31158.yann.morin.1998@anciens.enib.fr> (raw)
In-Reply-To: <4ECB8DEF.8000108@linaro.org>
Zhenqiang, All,
On Tuesday 22 November 2011 12:56:31 Zhenqiang Chen wrote:
> # HG changeset patch
> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> # Date 1321524028 -28800
> # Node ID e53dbc5ca50291b5258e19d1738fdf34e3a460ad
> # Parent 640bdfd7d1efc1b91ad54304fefe6db77179ec65
> cc/gcc: Add --disable-nls config when option "Enable nls" is not selected.
>
> Reviewed-by: Michael Hope
> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
>
> diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
> --- a/scripts/build/cc/gcc.sh
> +++ b/scripts/build/cc/gcc.sh
> @@ -289,6 +289,8 @@
> extra_config+=(--disable-libgomp)
> extra_config+=(--disable-libmudflap)
>
> + [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls")
Ditto the comment on the binutils patch.
> - # --disable-nls to work around crash bug on ppc405, but also because
> - # embedded systems don't really need message catalogs...
I agrre that this comment is misleading, as the catalogs are not for the
target, but fir the host; so the last part has to go, indeed.
But what worries me is the PPC405 breakage. Is it no longer breaking?
> CT_DoExecLog CFG \
> CC_FOR_BUILD="${CT_BUILD}-gcc" \
> CFLAGS="${CT_CFLAGS_FOR_HOST}" \
> @@ -617,7 +618,6 @@
> ${CC_SYSROOT_ARG} \
> "${extra_config[@]}" \
> --with-local-prefix="${CT_SYSROOT_DIR}" \
> - --disable-nls \
> --enable-c99 \
> --enable-long-long \
> "${CT_CC_EXTRA_CONFIG_ARRAY[@]}"
Otherwise, good!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
For unsubscribe information see http://sourceware.org/lists.html#faq
prev parent reply other threads:[~2011-11-22 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 11:57 Zhenqiang Chen
2011-11-22 17:26 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111221826.31158.yann.morin.1998@anciens.enib.fr \
--to=yann.morin.1998@anciens.enib.fr \
--cc=crossgcc@sourceware.org \
--cc=zhenqiang.chen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).