* [nls PATCH 3 of 3] cc/gcc: Handle --disable-nls config
@ 2011-11-22 11:57 Zhenqiang Chen
2011-11-22 17:26 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: Zhenqiang Chen @ 2011-11-22 11:57 UTC (permalink / raw)
To: yann.morin.1998; +Cc: crossgcc
# HG changeset patch
# User Zhenqiang Chen <zhenqiang.chen@linaro.org>
# Date 1321524028 -28800
# Node ID e53dbc5ca50291b5258e19d1738fdf34e3a460ad
# Parent 640bdfd7d1efc1b91ad54304fefe6db77179ec65
cc/gcc: Add --disable-nls config when option "Enable nls" is not selected.
Reviewed-by: Michael Hope
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
--- a/scripts/build/cc/gcc.sh
+++ b/scripts/build/cc/gcc.sh
@@ -289,6 +289,8 @@
extra_config+=(--disable-libgomp)
extra_config+=(--disable-libmudflap)
+ [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls")
+
CT_DoLog DEBUG "Extra config passed: '${extra_config[*]}'"
# Use --with-local-prefix so older gccs don't look in /usr/local (http://gcc.gnu.org/PR10532)
@@ -306,7 +308,6 @@
--disable-libmudflap \
${CC_CORE_SYSROOT_ARG} \
"${extra_config[@]}" \
- --disable-nls \
--enable-languages="${lang_opt}" \
"${CT_CC_CORE_EXTRA_CONFIG_ARRAY[@]}"
@@ -598,10 +599,10 @@
;; # ARCH is mips
esac
+ [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls")
+
CT_DoLog DEBUG "Extra config passed: '${extra_config[*]}'"
- # --disable-nls to work around crash bug on ppc405, but also because
- # embedded systems don't really need message catalogs...
CT_DoExecLog CFG \
CC_FOR_BUILD="${CT_BUILD}-gcc" \
CFLAGS="${CT_CFLAGS_FOR_HOST}" \
@@ -617,7 +618,6 @@
${CC_SYSROOT_ARG} \
"${extra_config[@]}" \
--with-local-prefix="${CT_SYSROOT_DIR}" \
- --disable-nls \
--enable-c99 \
--enable-long-long \
"${CT_CC_EXTRA_CONFIG_ARRAY[@]}"
--
For unsubscribe information see http://sourceware.org/lists.html#faq
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [nls PATCH 3 of 3] cc/gcc: Handle --disable-nls config
2011-11-22 11:57 [nls PATCH 3 of 3] cc/gcc: Handle --disable-nls config Zhenqiang Chen
@ 2011-11-22 17:26 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2011-11-22 17:26 UTC (permalink / raw)
To: crossgcc; +Cc: Zhenqiang Chen
Zhenqiang, All,
On Tuesday 22 November 2011 12:56:31 Zhenqiang Chen wrote:
> # HG changeset patch
> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> # Date 1321524028 -28800
> # Node ID e53dbc5ca50291b5258e19d1738fdf34e3a460ad
> # Parent 640bdfd7d1efc1b91ad54304fefe6db77179ec65
> cc/gcc: Add --disable-nls config when option "Enable nls" is not selected.
>
> Reviewed-by: Michael Hope
> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
>
> diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
> --- a/scripts/build/cc/gcc.sh
> +++ b/scripts/build/cc/gcc.sh
> @@ -289,6 +289,8 @@
> extra_config+=(--disable-libgomp)
> extra_config+=(--disable-libmudflap)
>
> + [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls")
Ditto the comment on the binutils patch.
> - # --disable-nls to work around crash bug on ppc405, but also because
> - # embedded systems don't really need message catalogs...
I agrre that this comment is misleading, as the catalogs are not for the
target, but fir the host; so the last part has to go, indeed.
But what worries me is the PPC405 breakage. Is it no longer breaking?
> CT_DoExecLog CFG \
> CC_FOR_BUILD="${CT_BUILD}-gcc" \
> CFLAGS="${CT_CFLAGS_FOR_HOST}" \
> @@ -617,7 +618,6 @@
> ${CC_SYSROOT_ARG} \
> "${extra_config[@]}" \
> --with-local-prefix="${CT_SYSROOT_DIR}" \
> - --disable-nls \
> --enable-c99 \
> --enable-long-long \
> "${CT_CC_EXTRA_CONFIG_ARRAY[@]}"
Otherwise, good!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
For unsubscribe information see http://sourceware.org/lists.html#faq
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-22 17:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-22 11:57 [nls PATCH 3 of 3] cc/gcc: Handle --disable-nls config Zhenqiang Chen
2011-11-22 17:26 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).