Re: GNU Make

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Daniel, All,

On 2014-01-15 14:15 -0800, Daniel Schultze spake thusly:
> Guys after working with CT-NG for a bit I found the patch directory
> and recreated my patch to work with the existing system:
> in $CT_NG/patches/glibc/2.10.1/920-glibc-2.10.1-manual-make.patch

Yep, that the correct way to add a new patch. :-)

Also, when submitting a patch, you should format it as such (without the
leading 4 spaces):

    component: short description

    One or more paragraph, if needed that describe in more details
    the issue you encountered, hy it happens, and how you fixed it.

    Signed-off-by: Your Real NAME <your.mail@somwhere.net>

For example, for this patch:

    libc/glibc: fix glibc-2.10 for use with make-3.82

    glibc-2.10's Makefile is broken because it mixes implicit and
    normal rules:
        Makefile:235: *** mixed implicit and normal rules. Stop.

    That's because make-3.82 removed this undocumented feature.

    Fix that by splitting the rules in two, as was done in:
        patches/glibc/2.12.1/920-make-382.patch

    Signed-off-by: you

This is all important, to:
  - quickly find the bug it the history log:    subject
  - understand the bug:                         first paragraph
  - confirm the reason:                         second paragraph
  - explain the fix:                            third paragraph
  - assess the origin of the patch:             SoB-line

It is not necessary to write long paragraphs, as long as all the relevant
information is present.

Some doc exists in the tree:
    docs/7 - Contributing to crosstool-NG.txt
    docs/C - Misc. tutorials.txt

Also, the SoB-line is explained in the doc, above, and there:
    http://elinux.org/Developer_Certificate_Of_Origin

The SoB-line is the only thing I can not add for you.

Care to resend with the above suggestions, please?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq