* GNU Make
@ 2014-01-15 18:21 Daniel Schultze
2014-01-15 22:15 ` Daniel Schultze
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Schultze @ 2014-01-15 18:21 UTC (permalink / raw)
To: crossgcc
Hey guys,
I'm new to crosstool-ng, so far it looks like a good utility. I want
to contribute a patch for glibc 2.10.1 as it will correct its known
issue with implicit and explicit rules on the same line. Other patches
can follow the same pattern of moving the rules to separate lines.
--- glibc-2.10.1/glibc-2.10.1/manual/Makefile-orig 2013-12-06
11:03:33.170318872 -0800
+++ glibc-2.10.1/glibc-2.10.1/manual/Makefile 2013-12-06
11:02:35.555022786 -0800
@@ -232,7 +232,11 @@
.PHONY: stubs
stubs: $(objpfx)stubs
endif
-$(objpfx)stubs ../po/manual.pot $(objpfx)stamp%:
+$(objpfx)stamp%:
+ $(make-target-directory)
+ touch $@
+
+$(objpfx)stubs ../po/manual.pot:
$(make-target-directory)
touch $@
-Dan
--
For unsubscribe information see http://sourceware.org/lists.html#faq
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: GNU Make
2014-01-15 18:21 GNU Make Daniel Schultze
@ 2014-01-15 22:15 ` Daniel Schultze
2014-01-15 23:17 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Schultze @ 2014-01-15 22:15 UTC (permalink / raw)
To: crossgcc
Guys after working with CT-NG for a bit I found the patch directory
and recreated my patch to work with the existing system:
in $CT_NG/patches/glibc/2.10.1/920-glibc-2.10.1-manual-make.patch
diff -urN glibc-2.10.1-orig/manual/Makefile glibc-2.10.1/manual/Makefile
--- glibc-2.10.1-orig/manual/Makefile 2006-01-07 22:43:47.000000000 -0800
+++ glibc-2.10.1/manual/Makefile 2014-01-15 11:49:08.256982014 -0800
@@ -232,7 +232,11 @@
.PHONY: stubs
stubs: $(objpfx)stubs
endif
-$(objpfx)stubs ../po/manual.pot $(objpfx)stamp%:
+$(objpfx)stamp%:
+ $(make-target-directory)
+ touch $@
+
+$(objpfx)stubs ../po/manual.pot:
$(make-target-directory)
touch $@
On Wed, Jan 15, 2014 at 10:21 AM, Daniel Schultze <kinglag@gmail.com> wrote:
> Hey guys,
>
> I'm new to crosstool-ng, so far it looks like a good utility. I want
> to contribute a patch for glibc 2.10.1 as it will correct its known
> issue with implicit and explicit rules on the same line. Other patches
> can follow the same pattern of moving the rules to separate lines.
>
>
>
> --- glibc-2.10.1/glibc-2.10.1/manual/Makefile-orig 2013-12-06
> 11:03:33.170318872 -0800
> +++ glibc-2.10.1/glibc-2.10.1/manual/Makefile 2013-12-06
> 11:02:35.555022786 -0800
> @@ -232,7 +232,11 @@
> .PHONY: stubs
> stubs: $(objpfx)stubs
> endif
> -$(objpfx)stubs ../po/manual.pot $(objpfx)stamp%:
> +$(objpfx)stamp%:
> + $(make-target-directory)
> + touch $@
> +
> +$(objpfx)stubs ../po/manual.pot:
> $(make-target-directory)
> touch $@
>
> -Dan
--
For unsubscribe information see http://sourceware.org/lists.html#faq
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: GNU Make
2014-01-15 22:15 ` Daniel Schultze
@ 2014-01-15 23:17 ` Yann E. MORIN
0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-01-15 23:17 UTC (permalink / raw)
To: Daniel Schultze; +Cc: crossgcc
Daniel, All,
On 2014-01-15 14:15 -0800, Daniel Schultze spake thusly:
> Guys after working with CT-NG for a bit I found the patch directory
> and recreated my patch to work with the existing system:
> in $CT_NG/patches/glibc/2.10.1/920-glibc-2.10.1-manual-make.patch
Yep, that the correct way to add a new patch. :-)
Also, when submitting a patch, you should format it as such (without the
leading 4 spaces):
component: short description
One or more paragraph, if needed that describe in more details
the issue you encountered, hy it happens, and how you fixed it.
Signed-off-by: Your Real NAME <your.mail@somwhere.net>
For example, for this patch:
libc/glibc: fix glibc-2.10 for use with make-3.82
glibc-2.10's Makefile is broken because it mixes implicit and
normal rules:
Makefile:235: *** mixed implicit and normal rules. Stop.
That's because make-3.82 removed this undocumented feature.
Fix that by splitting the rules in two, as was done in:
patches/glibc/2.12.1/920-make-382.patch
Signed-off-by: you
This is all important, to:
- quickly find the bug it the history log: subject
- understand the bug: first paragraph
- confirm the reason: second paragraph
- explain the fix: third paragraph
- assess the origin of the patch: SoB-line
It is not necessary to write long paragraphs, as long as all the relevant
information is present.
Some doc exists in the tree:
docs/7 - Contributing to crosstool-NG.txt
docs/C - Misc. tutorials.txt
Also, the SoB-line is explained in the doc, above, and there:
http://elinux.org/Developer_Certificate_Of_Origin
The SoB-line is the only thing I can not add for you.
Care to resend with the above suggestions, please?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
For unsubscribe information see http://sourceware.org/lists.html#faq
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-15 23:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-15 18:21 GNU Make Daniel Schultze
2014-01-15 22:15 ` Daniel Schultze
2014-01-15 23:17 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).