public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: "Jason Pyeron" <jpyeron@pdinc.us>
To: <cygwin-apps@cygwin.com>
Subject: RE: cygport test has zero exit status on failures
Date: Tue, 18 May 2021 16:57:00 -0400	[thread overview]
Message-ID: <051901d74c28$58efeac0$0acfc040$@pdinc.us> (raw)
In-Reply-To: <87k0nvdcho.fsf@Rainer.invalid>

> -----Original Message-----
> From: Achim Gratz
> Sent: Tuesday, May 18, 2021 4:16 PM
> 
> Jason Pyeron writes:
> > If I put it in ~/.config/cygport.conf it will impact all packages, not
> > just the "one". The only place it is limited to applicable package is
> > in the package.cygport file, or am I missing something?
> 
> You can always override these settings when starting a build on a CI
> (either by changing the config file or just remove/set more environment
> variables), but the point was that the cygport file should not lock in a
> specific behaviour, but rather allow the environment to determine it.

Having trouble groking the conceptual design.

If I have a CI build for *.cygport - is it expected to have conditional logic based on which package is being processed? 

I thought was the purpose of the cygport file [1] was to contain only the compiling, testing, and installation instructions, just like portage [2]. 

In any case the all or all-test does not execute the test step, so the customization of the src_test does not impact the default behaviors.

As an example you can look at my CI builds [3] to see the sequence: 

1. ensure dependencies are installed on build host
2. cygport file.cygport download
3. cygport file.cygport all-test
4. cygport file.cygport test
5. archive artifacts

The same build host is used (serially) for other builds.

-Jason

1: /usr/share/doc/cygport/README §2
2: https://devmanual.gentoo.org/ebuild-writing/functions/src_test/index.html
3: https://www.pdinc.us/ci/job/oss-cygwin-pdfgrep/job/cygwin-cygport-2.1.2/3/


  reply	other threads:[~2021-05-18 20:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-09 21:12 Jason Pyeron
2021-05-10  5:06 ` ASSI
2021-05-17 22:29   ` Jason Pyeron
2021-05-18  4:36     ` ASSI
2021-05-18 19:17       ` Jason Pyeron
2021-05-18 20:16         ` Achim Gratz
2021-05-18 20:57           ` Jason Pyeron [this message]
2021-05-19  5:16             ` ASSI
2021-05-19  7:05               ` Marco Atzeri
2021-05-19 16:32                 ` Jason Pyeron
2021-05-19 17:14                   ` Achim Gratz
2021-05-19 17:24                   ` Marco Atzeri
2021-05-19 17:30                     ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='051901d74c28$58efeac0$0acfc040$@pdinc.us' \
    --to=jpyeron@pdinc.us \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).