From: Marco Atzeri <marco.atzeri@gmail.com>
To: cygwin-apps@cygwin.com
Subject: Re: cygport test has zero exit status on failures
Date: Wed, 19 May 2021 19:24:15 +0200 [thread overview]
Message-ID: <4368ad4c-6b3e-07db-e88c-b66ba54fa906@gmail.com> (raw)
In-Reply-To: <6d3701d74ccc$9ec1cf60$dc456e20$@pdinc.us>
On 19.05.2021 18:32, Jason Pyeron wrote:
>> -----Original Message-----
>> From: Marco Atzeri
>> Sent: Wednesday, May 19, 2021 3:06 AM
>>
>> On 19.05.2021 07:16, ASSI wrote:
>>> Jason Pyeron writes:
>>
>>>
>>> cygport $p finish prep compile inst test pkg
>
> So for the pdfgrep that I am going to maintain, is it acceptable that I want the package to not happen until I address the test failure? Like so?
you are the maintainer, it is your decision.
We just give you our opinion based on our experience
> ...
> BUILD_REQUIRES="asciidoc gcc-g++ libpoppler-cpp-devel libgcrypt-devel libpcre-devel dejagnu texlive-collection-latex docbook-xml45"
>
> src_test() {
> cd ${B}
> make check
> }
This is the default.
>> in general a generic test failure is not a valid reason to NOT package.
>> Most of my packages have peculiar test failures that can be just ignored
>>
>> In several, I just use "cygmake -i check" in src_test
>> to avoid premature stop of the tests.
>>
>> Others requires to be installed before the testsuite is
>> properly executed.
>
> Since it is not required to be installed, I would like to lean towards stopping to fix first.
The 1.4.1 seems fine. Or I am missing something ?
>
> v/r,
>
> Jason
>
Regards
Marco
next prev parent reply other threads:[~2021-05-19 17:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 21:12 Jason Pyeron
2021-05-10 5:06 ` ASSI
2021-05-17 22:29 ` Jason Pyeron
2021-05-18 4:36 ` ASSI
2021-05-18 19:17 ` Jason Pyeron
2021-05-18 20:16 ` Achim Gratz
2021-05-18 20:57 ` Jason Pyeron
2021-05-19 5:16 ` ASSI
2021-05-19 7:05 ` Marco Atzeri
2021-05-19 16:32 ` Jason Pyeron
2021-05-19 17:14 ` Achim Gratz
2021-05-19 17:24 ` Marco Atzeri [this message]
2021-05-19 17:30 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4368ad4c-6b3e-07db-e88c-b66ba54fa906@gmail.com \
--to=marco.atzeri@gmail.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).