public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: Takashi Yano <takashi.yano@nifty.ne.jp>,
	"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [ITP] moc (2.6.r3005)
Date: Thu, 16 Feb 2023 18:48:24 +0000	[thread overview]
Message-ID: <0932aaa8-f4ce-f2a4-8da7-8c486cdaec14@dronecode.org.uk> (raw)
In-Reply-To: <20230214181110.e0be6c4b43bdff087751959b@nifty.ne.jp>

On 14/02/2023 09:11, Takashi Yano via Cygwin-apps wrote:
> On Mon, 13 Feb 2023 18:25:43 +0000
> Jon Turney wrote:
>> On 09/02/2023 12:54, Takashi Yano via Cygwin-apps wrote:
>>> NAME="moc"
>>> VERSION=2.6.r3005
>>> RELEASE=1
>> [...]
>>> SVN_URI="svn://svn.daper.net/moc/trunk"
>>> SVN_REV="3005"
>>> inherit svn
>>
>> You could (and probably should) write this as
>>
>> SVN_REV=${VERSION##*.r}
>>
>> so you don't have to remember to update it in both places.
>>
>> (See 'Remove matching prefix pattern' in the section 'Parameter
>> Expansion' in 'man bash')
>>
>>
>> Otherwise, looks good.
> 
> Thanks. I revised the cygport file.

Approved.


      reply	other threads:[~2023-02-16 18:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 10:36 Takashi Yano
2023-02-05 16:35 ` Jon Turney
2023-02-06 13:58   ` Takashi Yano
2023-02-09 12:54     ` Takashi Yano
2023-02-13 18:25       ` Jon Turney
2023-02-14  9:11         ` Takashi Yano
2023-02-16 18:48           ` Jon Turney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0932aaa8-f4ce-f2a4-8da7-8c486cdaec14@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    --cc=takashi.yano@nifty.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).