cygport: 'announce' feature branch

cygport: 'announce' feature branch

[Yaakov Selkowitz]

I just created a new 'announce' feature branch in cygport git:

https://github.com/cygwinports/cygport/tree/announce

The new 'announce' command generates an announcement template from
the .cygport file based on NAME/VERSION/RELEASE, PKG_NAMES, and
DESCRIPTION, to which you can easily add release-specific information,
and then sends the message via an SMTP server.  Note that this adds
dependencies on perl-Authen-SASL, perl-MIME-tools, and
perl-Net-SMTP-SSL, and requires several new SMTP_* configuration options
in cygport.conf.

Feedback and patches welcome.

--
Yaakov

Re: cygport: 'announce' feature branch

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

On Nov  3 02:06, Yaakov Selkowitz wrote:
> I just created a new 'announce' feature branch in cygport git:
> 
> https://github.com/cygwinports/cygport/tree/announce
> 
> The new 'announce' command generates an announcement template from
> the .cygport file based on NAME/VERSION/RELEASE, PKG_NAMES, and
> DESCRIPTION, to which you can easily add release-specific information,
> and then sends the message via an SMTP server.  Note that this adds
> dependencies on perl-Authen-SASL, perl-MIME-tools, and
> perl-Net-SMTP-SSL, and requires several new SMTP_* configuration options
> in cygport.conf.
> 
> Feedback and patches welcome.

Sounds cool.  Do you have an example how to configure and use it?


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: cygport: 'announce' feature branch

[Yaakov Selkowitz]

On Tue, 2015-11-03 at 09:57 +0100, Corinna Vinschen wrote:
> On Nov  3 02:06, Yaakov Selkowitz wrote:
> > I just created a new 'announce' feature branch in cygport git:
> > 
> > https://github.com/cygwinports/cygport/tree/announce
> > 
> > The new 'announce' command generates an announcement template from
> > the .cygport file based on NAME/VERSION/RELEASE, PKG_NAMES, and
> > DESCRIPTION, to which you can easily add release-specific information,
> > and then sends the message via an SMTP server.  Note that this adds
> > dependencies on perl-Authen-SASL, perl-MIME-tools, and
> > perl-Net-SMTP-SSL, and requires several new SMTP_* configuration options
> > in cygport.conf.
> > 
> > Feedback and patches welcome.
> 
> Sounds cool.  Do you have an example how to configure and use it?

The new settings are all documented in data/cygport.conf, and are
similar in concept to the sendemail.from and sendemail.stmp* settings in
git; if you have git send-email working then this should be
straight-forward.  Just be sure to 0600 your file if you store an
SMTP_PASS (as mentioned in the documentation).

Once configured, run 'cygport NAME.cygport announce' and it will open a
template email in mbox format in $EDITOR; add any release-specific
information, exit the editor normally, and the email is sent.

What this does need still is robustness; e.g. being able to cancel
sending the announcement, or dealing with a misformed mbox caused by
poor editing.  The ability to automatically add a signature may also be
desirable.

As for the results, my announcements from last night starting from gmic
on were all generated by cygport announce.

--
Yaakov

Re: cygport: 'announce' feature branch

[Ken Brown]

On 11/3/2015 3:06 AM, Yaakov Selkowitz wrote:
> I just created a new 'announce' feature branch in cygport git:
>
> https://github.com/cygwinports/cygport/tree/announce
>
> The new 'announce' command generates an announcement template from
> the .cygport file based on NAME/VERSION/RELEASE, PKG_NAMES, and
> DESCRIPTION, to which you can easily add release-specific information,
> and then sends the message via an SMTP server.  Note that this adds

This is a nice feature.  Thanks.

> dependencies on perl-Authen-SASL, perl-MIME-tools, and

perl-MIME-tools isn't in the distro yet.  Achim?

> perl-Net-SMTP-SSL, and requires several new SMTP_* configuration options
> in cygport.conf.
>
> Feedback and patches welcome.

If there's no mailserver configured, I'd like to see cygport save the 
mbox file in the current directory and give an informational message, 
rather than saving it in /tmp and giving an error message.  Users might 
want to simply paste it into an email, and the error message seems a 
little unfriendly.

Ken

P.S. You still haven't applied the texlive patch from 
https://cygwin.com/ml/cygwin-apps/2015-08/msg00019.html; is this just an 
oversight, or do you need me to explain in more detail why it's needed?

Re: cygport: 'announce' feature branch

[Yaakov Selkowitz]

On Tue, 2015-11-03 at 18:23 -0500, Ken Brown wrote:
> On 11/3/2015 3:06 AM, Yaakov Selkowitz wrote:
> > I just created a new 'announce' feature branch in cygport git:
> >
> > https://github.com/cygwinports/cygport/tree/announce
> >
> > The new 'announce' command generates an announcement template from
> > the .cygport file based on NAME/VERSION/RELEASE, PKG_NAMES, and
> > DESCRIPTION, to which you can easily add release-specific information,
> > and then sends the message via an SMTP server.  Note that this adds
> 
> This is a nice feature.  Thanks.
> 
> > dependencies on perl-Authen-SASL, perl-MIME-tools, and
> 
> perl-MIME-tools isn't in the distro yet.

Good point, I just moved it in from Ports.

> If there's no mailserver configured, I'd like to see cygport save the 
> mbox file in the current directory and give an informational message, 
> rather than saving it in /tmp and giving an error message.  Users might 
> want to simply paste it into an email, and the error message seems a 
> little unfriendly.

First, I have already changed SMTP_SERVER to default to localhost,
matching git's behaviour.  (If it wasn't already painfully obvious, this
is all modelled after git send-email.)  Therefore, the error message now
reflects an actual failure to send the message.  As for the location of
the mbox file, it's something I'm willing to consider.

> P.S. You still haven't applied the texlive patch from 
> https://cygwin.com/ml/cygwin-apps/2015-08/msg00019.html; is this just an 
> oversight, or do you need me to explain in more detail why it's needed?

Oversight; August was a busy month.  Applied.

--
Yaakov

Re: cygport: 'announce' feature branch

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

On Nov  3 18:10, Yaakov Selkowitz wrote:
> On Tue, 2015-11-03 at 18:23 -0500, Ken Brown wrote:
> > On 11/3/2015 3:06 AM, Yaakov Selkowitz wrote:
> > > I just created a new 'announce' feature branch in cygport git:
> > >
> > > https://github.com/cygwinports/cygport/tree/announce
> > >
> > > The new 'announce' command generates an announcement template from
> > > the .cygport file based on NAME/VERSION/RELEASE, PKG_NAMES, and
> > > DESCRIPTION, to which you can easily add release-specific information,
> > > and then sends the message via an SMTP server.  Note that this adds
> > 
> > This is a nice feature.  Thanks.
> > 
> > > dependencies on perl-Authen-SASL, perl-MIME-tools, and
> > 
> > perl-MIME-tools isn't in the distro yet.
> 
> Good point, I just moved it in from Ports.
> 
> > If there's no mailserver configured, I'd like to see cygport save the 
> > mbox file in the current directory and give an informational message, 
> > rather than saving it in /tmp and giving an error message.  Users might 
> > want to simply paste it into an email, and the error message seems a 
> > little unfriendly.
> 
> First, I have already changed SMTP_SERVER to default to localhost,
> matching git's behaviour.  (If it wasn't already painfully obvious, this
> is all modelled after git send-email.)  Therefore, the error message now
> reflects an actual failure to send the message.  As for the location of
> the mbox file, it's something I'm willing to consider.

I agree with Ken.  $PWD or perhaps $HOME would be nice.  $PWD seems
the most obvious choice.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: cygport: 'announce' feature branch

[Ken Brown]

On 11/3/2015 7:10 PM, Yaakov Selkowitz wrote:
> On Tue, 2015-11-03 at 18:23 -0500, Ken Brown wrote:
>> If there's no mailserver configured, I'd like to see cygport save the
>> mbox file in the current directory and give an informational message,
>> rather than saving it in /tmp and giving an error message.  Users might
>> want to simply paste it into an email, and the error message seems a
>> little unfriendly.
>
> First, I have already changed SMTP_SERVER to default to localhost,
> matching git's behaviour.  (If it wasn't already painfully obvious, this
> is all modelled after git send-email.)  Therefore, the error message now
> reflects an actual failure to send the message.

The analogy with git explains my reaction.  cygport announce strikes me 
as a combination of git format-patch and git send-email.  In my own use 
of git, I've never bothered to configure git send-email.  I just use git 
format-patch and paste it or attach it to an email.  So I was expecting 
to use cygport announce the same way.  And I can in fact use it the same 
way, but it tells me there's an error.  That's OK.  I'll try not to take 
it personally.

Ken

Re: cygport: 'announce' feature branch

[Ken Brown]

On 11/4/2015 11:12 AM, Ken Brown wrote:
> On 11/3/2015 7:10 PM, Yaakov Selkowitz wrote:
>> On Tue, 2015-11-03 at 18:23 -0500, Ken Brown wrote:
>>> If there's no mailserver configured, I'd like to see cygport save the
>>> mbox file in the current directory and give an informational message,
>>> rather than saving it in /tmp and giving an error message.  Users might
>>> want to simply paste it into an email, and the error message seems a
>>> little unfriendly.
>>
>> First, I have already changed SMTP_SERVER to default to localhost,
>> matching git's behaviour.  (If it wasn't already painfully obvious, this
>> is all modelled after git send-email.)  Therefore, the error message now
>> reflects an actual failure to send the message.
>
> The analogy with git explains my reaction.  cygport announce strikes me
> as a combination of git format-patch and git send-email.  In my own use
> of git, I've never bothered to configure git send-email.  I just use git
> format-patch and paste it or attach it to an email.  So I was expecting
> to use cygport announce the same way.  And I can in fact use it the same
> way, but it tells me there's an error.  That's OK.  I'll try not to take
> it personally.

I went ahead and configured the SMTP_* variables in .cygport.conf, but I 
didn't want to put my password in that file.  So I left SMTP_PASS unset. 
  This resulted in the following:

Sending announcement of emacs-auctex-11.89-1 via smtp.cornell.edu
unable to set username and password at /dev/fd/63 line 30.
*** ERROR: Sending announcement failed, mbox is 
/tmp/cygwin-announce-emacs-auctex-11.89-1.12cyxI

I suggest that cygport prompt the user for a password in this situation, 
the way git send-email does.

Ken