public inbox for
 help / color / mirror / Atom feed
From: Adam Dinwoodie <>
Subject: Cygport configure script argument handling
Date: Thu, 10 Mar 2022 16:41:57 +0000	[thread overview]
Message-ID: <> (raw)

I've fallen down a slight rabbit hole looking at the cygconf function in
Cygport's autotools.cygclass.  The specific bit of code that's causing
me consternation is thus:

	case "x${confver}" in
			confargs+=" --docdir=/usr/share/doc/${PN} --htmldir=/usr/share/doc/${PN}/html"
			confargs+=" --infodir=${prefix}/share/info --mandir=${prefix}/share/man"

Firstly, I think the glob is incorrect: it looks like it was intended to
match files that came from Autoconf versions 2.60 and up -- 2.60 is when
Autoconf added the docdir and htmldir arguments -- but it has stopped
working as expected: Autoconf released 2.70 in December 2020, and is now
up to 2.71.  The above code won't match those versions.

Secondly -- and I'm not sure if this is intended or not -- I don't
understand why --infodir and --mandir are only defined for versions
prior to 2.60 (and, apparently unintentionally, 2.70 onwards).  Those
are valid both before and after 2.60.  My best guess is that the intent
was for the first option to fall through to the second, so for 2.60+ all
four options would be defined, but that would have required `;&` or
`;;&` rather than `;;`.

Can anyone explain what the intent of this code is?  Are these both the
bugs that I think they are, or am I missing the intent?

             reply	other threads:[~2022-03-10 16:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 16:41 Adam Dinwoodie [this message]
2022-03-11  5:38 ` Yaakov Selkowitz
2022-03-11  9:05   ` Adam Dinwoodie
2022-03-11 22:40     ` [PATCH cygport] autotools.cygclass: correctly detect Autoconf 2.70+ Adam Dinwoodie
2022-03-12 13:02       ` Jon Turney
2022-03-13 20:31         ` Adam Dinwoodie
2022-03-13 20:44         ` [PATCH cygport v2] " Adam Dinwoodie
2022-03-14 19:05           ` Jon Turney
2022-03-14 21:05             ` Adam Dinwoodie
2022-03-14 22:15               ` [PATCH cygport v3] " Adam Dinwoodie
2022-04-13 17:58                 ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).