From: Adam Dinwoodie <adam@dinwoodie.org>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH cygport v2] autotools.cygclass: correctly detect Autoconf 2.70+
Date: Mon, 14 Mar 2022 21:05:39 +0000 [thread overview]
Message-ID: <20220314210539.inhr45iiryiqkcqd@lucy.dinwoodie.org> (raw)
In-Reply-To: <2d35d2f7-dd39-1cc8-e598-38e14cdd763b@dronecode.org.uk>
On Mon, Mar 14, 2022 at 07:05:20PM +0000, Jon Turney wrote:
> On 13/03/2022 20:44, Adam Dinwoodie wrote:
> > configure="${confdir}/configure"
> > confver=$(grep -m 1 'GNU Autoconf' ${configure} | cut -d ' ' -f 6)
> > + confver_maj=${confver%%.*}
> > + confver_min=${confver##*.}
> > + if [ $confver_maj -ne 2 ]
> > + then
> > + error "unexpected autoconf version";
> > + fi
> > # AC_CONFIG_FILES should not be dist'ed, but it sometimes happens anyway
> > eval $(grep -h '^ac_config_files=' ${configure})
>
> When I test this locally, it fails, as (note the full stop at the end of the
> line):
>
> > $ grep -m1 Autoconf configure
> > # Generated by GNU Autoconf 2.71.
Huh. Apparently that string has a less consistent format than I'd
assumed; I'd tested that line against the configure script for Git, but
that gets different behaviour:
$ grep -m1 Autoconf git-2.35.1-2.x86_64/build/configure
# Generated by GNU Autoconf 2.71 for git 2.35.1.
I'll try to come up with something a bit less fragile...
next prev parent reply other threads:[~2022-03-14 21:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 16:41 Cygport configure script argument handling Adam Dinwoodie
2022-03-11 5:38 ` Yaakov Selkowitz
2022-03-11 9:05 ` Adam Dinwoodie
2022-03-11 22:40 ` [PATCH cygport] autotools.cygclass: correctly detect Autoconf 2.70+ Adam Dinwoodie
2022-03-12 13:02 ` Jon Turney
2022-03-13 20:31 ` Adam Dinwoodie
2022-03-13 20:44 ` [PATCH cygport v2] " Adam Dinwoodie
2022-03-14 19:05 ` Jon Turney
2022-03-14 21:05 ` Adam Dinwoodie [this message]
2022-03-14 22:15 ` [PATCH cygport v3] " Adam Dinwoodie
2022-04-13 17:58 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314210539.inhr45iiryiqkcqd@lucy.dinwoodie.org \
--to=adam@dinwoodie.org \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).