From: Adam Dinwoodie <adam@dinwoodie.org>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH cygport] autotools.cygclass: correctly detect Autoconf 2.70+
Date: Sun, 13 Mar 2022 20:31:23 +0000 [thread overview]
Message-ID: <20220313203123.2g5uimv76n7rm3en@lucy.dinwoodie.org> (raw)
In-Reply-To: <70a9c487-e302-5342-61ce-5b917d089ec6@dronecode.org.uk>
On Sat, Mar 12, 2022 at 01:02:39PM +0000, Jon Turney wrote:
> On 11/03/2022 22:40, Adam Dinwoodie wrote:
> > - case "x${confver}" in
> > - x2.6[0-9]*)
> > - confargs+=" --docdir=/usr/share/doc/${PN} --htmldir=/usr/share/doc/${PN}/html"
> > - ;;
> > - *)
> > - confargs+=" --infodir=${prefix}/share/info --mandir=${prefix}/share/man"
> > - ;;
> > - esac
> > + if [ $confver_maj -ge 2 -a $confver_min -ge 60 ] || [ $confver_maj -ge 3 ]
>
> Great. Thanks.
>
> I think it would be acceptable to error on autoconf >=3.0, rather than
> assuming it's going to be autoconf 2.6+ compatible.
No problem, I'll respin now. I'd thought about doing exactly that, but
the current code looked like it was designed to assume things would be
fine unless there was a specific reason to bail out, so I tried to
follow that paradigm rather than bail out when there was no known reason
for doing so.
next prev parent reply other threads:[~2022-03-13 20:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 16:41 Cygport configure script argument handling Adam Dinwoodie
2022-03-11 5:38 ` Yaakov Selkowitz
2022-03-11 9:05 ` Adam Dinwoodie
2022-03-11 22:40 ` [PATCH cygport] autotools.cygclass: correctly detect Autoconf 2.70+ Adam Dinwoodie
2022-03-12 13:02 ` Jon Turney
2022-03-13 20:31 ` Adam Dinwoodie [this message]
2022-03-13 20:44 ` [PATCH cygport v2] " Adam Dinwoodie
2022-03-14 19:05 ` Jon Turney
2022-03-14 21:05 ` Adam Dinwoodie
2022-03-14 22:15 ` [PATCH cygport v3] " Adam Dinwoodie
2022-04-13 17:58 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220313203123.2g5uimv76n7rm3en@lucy.dinwoodie.org \
--to=adam@dinwoodie.org \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).