public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [ITA] SDL2 (2.26.2)
Date: Sun, 22 Jan 2023 21:05:50 +0900	[thread overview]
Message-ID: <20230122210550.0c7fa8aedaa8ebf7dc772dbc@nifty.ne.jp> (raw)
In-Reply-To: <f6220435-e6bc-9f7f-f043-fd22cf58c730@dronecode.org.uk>

On Sat, 21 Jan 2023 14:58:55 +0000
Jon Turney wrote:
> You've made some changes in the configuration here (switching from 
> enabling pulseaudio to oss)
> 
> I think you've also dropped the winmm patch.
> 
> I don't understand enough to evaluate the correctness those changes, so 
> it would be nice if you could explain that to me.

Thanks for reviewing. The reason why I turnd off pulseaudio
is that the latency was unacceptably large, despite the fact
that pulseaudio is preferred over other sound drivers.
Due to this, ffplay missynchronized sound with video.

Also, I guess OSS was previously disabled because it does not
work as expected due to a bug of cygwin:
https://cygwin.com/pipermail/cygwin-patches/2023q1/012134.html
and winmm was enabled instead.

Now, the bug has been fixed and SDL2 gets working with OSS.
Therefore, we don't need winmm support anymore. I think
it is better not to call winmm directly from cygwin apps.

BTW, I tried to modify SDL2 code to minimize the latency of
pulseaudio and it succeeded. So, I re-enabled the pulseaudio
and updated the package.

Could you please review the package again?

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

  parent reply	other threads:[~2023-01-22 12:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 10:35 Takashi Yano
2023-01-21 14:58 ` Jon Turney
2023-01-21 22:07   ` Brian Inglis
2023-01-22 12:05   ` Takashi Yano [this message]
2023-01-28 16:24     ` Jon Turney
2023-02-09 13:10       ` Takashi Yano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230122210550.0c7fa8aedaa8ebf7dc772dbc@nifty.ne.jp \
    --to=takashi.yano@nifty.ne.jp \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).