public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* untest failing with TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'
@ 2023-01-21 23:57 Brian Inglis
  2023-01-22  6:34 ` Brian Inglis
  0 siblings, 1 reply; 5+ messages in thread
From: Brian Inglis @ 2023-01-21 23:57 UTC (permalink / raw)
  To: cygwin-apps

$ ssh cygwin untest dash-0.5.12-1
Traceback (most recent call last):
   File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
     "__main__", mod_spec)
   File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
     exec(code, run_globals)
   File "/sourceware/cygwin-staging/calm/calm/untest.py", line 83, in <module>
     sys.exit(main())
   File "/sourceware/cygwin-staging/calm/calm/untest.py", line 79, in main
     untest(p)
   File "/sourceware/cygwin-staging/calm/calm/untest.py", line 39, in untest
     if not tool_util.permitted(p):
   File "/sourceware/cygwin-staging/calm/calm/tool_util.py", line 50, in permitted
     mlist = maintainers.add_packages(mlist, common_constants.PKGMAINT, 
trustedMaint=common_constants.TRUSTEDMAINT)
TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'

-- 
Take care. Thanks, Brian Inglis			Calgary, Alberta, Canada

La perfection est atteinte			Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter	not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer	but when there is no more to cut
			-- Antoine de Saint-Exupéry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: untest failing with TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'
  2023-01-21 23:57 untest failing with TypeError: add_packages() got an unexpected keyword argument 'trustedMaint' Brian Inglis
@ 2023-01-22  6:34 ` Brian Inglis
  2023-01-22 10:59   ` Jon Turney
  0 siblings, 1 reply; 5+ messages in thread
From: Brian Inglis @ 2023-01-22  6:34 UTC (permalink / raw)
  To: cygwin-apps

On 2023-01-21 16:57, Brian Inglis via Cygwin-apps wrote:
> $ ssh cygwin untest dash-0.5.12-1
> Traceback (most recent call last):
>    File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
>      "__main__", mod_spec)
>    File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
>      exec(code, run_globals)
>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 83, in <module>
>      sys.exit(main())
>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 79, in main
>      untest(p)
>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 39, in untest
>      if not tool_util.permitted(p):
>    File "/sourceware/cygwin-staging/calm/calm/tool_util.py", line 50, in permitted
>      mlist = maintainers.add_packages(mlist, common_constants.PKGMAINT, 
> trustedMaint=common_constants.TRUSTEDMAINT)
> TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'

Allowed keyword arguments were only orphanMaint and prev_maint:

$ grep -H add_packages /usr/lib/python3.?/site-packages/**/maintainers*
/usr/lib/python3.9/site-packages/calm/maintainers.py:def add_packages(mlist, 
pkglist, orphanMaint=None, prev_maint=True):
/usr/lib/python3.9/site-packages/calm/maintainers.py:    mlist = 
add_packages(mlist, args.pkglist, orphanmaint, prev_maint)

Commit ad6b47c27b1113abacdfebf7234d38b6524606cd

https://cygwin.com/git/?p=cygwin-apps/calm.git;a=commitdiff;h=ad6b47c27b1113abacdfebf7234d38b6524606cd

removes orphanMaint but does not add trustedMaint in def:

https://cygwin.com/git/?p=cygwin-apps%2Fcalm.git&a=search&h=HEAD&st=grep&s=add_packages

calm/maintainers.py	
  139 def add_packages(mlist, pkglist, prev_maint=True):
  201     mlist = add_packages(mlist, args.pkglist, prev_maint)
calm/mkgitoliteconf.py	
   54     mlist = maintainers.add_packages(mlist, args.pkglist)
calm/package.py	
1091     mlist = maintainers.add_packages(mlist, args.pkglist)
calm/tool_util.py	
   50     mlist = maintainers.add_packages(mlist, common_constants.PKGMAINT, 
trustedMaint=common_constants.TRUSTEDMAINT)
test/test_calm.py	
  322         mlist = maintainers.add_packages(mlist, 
'testdata/pkglist/cygwin-pkg-maint')

Newer version not pushed, built, or installed on site?

-- 
Take care. Thanks, Brian Inglis			Calgary, Alberta, Canada

La perfection est atteinte			Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter	not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer	but when there is no more to cut
			-- Antoine de Saint-Exupéry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: untest failing with TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'
  2023-01-22  6:34 ` Brian Inglis
@ 2023-01-22 10:59   ` Jon Turney
  2023-01-22 18:46     ` Brian Inglis
  0 siblings, 1 reply; 5+ messages in thread
From: Jon Turney @ 2023-01-22 10:59 UTC (permalink / raw)
  To: Brian Inglis, cygwin-apps

On 22/01/2023 06:34, Brian Inglis via Cygwin-apps wrote:
> On 2023-01-21 16:57, Brian Inglis via Cygwin-apps wrote:
>> $ ssh cygwin untest dash-0.5.12-1
>> Traceback (most recent call last):
>>    File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
>>      "__main__", mod_spec)
>>    File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
>>      exec(code, run_globals)
>>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 83, in 
>> <module>
>>      sys.exit(main())
>>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 79, in 
>> main
>>      untest(p)
>>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 39, in 
>> untest
>>      if not tool_util.permitted(p):
>>    File "/sourceware/cygwin-staging/calm/calm/tool_util.py", line 50, 
>> in permitted
>>      mlist = maintainers.add_packages(mlist, 
>> common_constants.PKGMAINT, trustedMaint=common_constants.TRUSTEDMAINT)
>> TypeError: add_packages() got an unexpected keyword argument 
>> 'trustedMaint'

Thanks for reporting this.

[...]
> Newer version not pushed, built, or installed on site?

No, just a bug I introduced.  I've had a go at fixing it, please try 
again now.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: untest failing with TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'
  2023-01-22 10:59   ` Jon Turney
@ 2023-01-22 18:46     ` Brian Inglis
  2023-01-22 22:01       ` Brian Inglis
  0 siblings, 1 reply; 5+ messages in thread
From: Brian Inglis @ 2023-01-22 18:46 UTC (permalink / raw)
  To: cygwin-apps; +Cc: Jon Turney

On 2023-01-22 03:59, Jon Turney wrote:
> On 22/01/2023 06:34, Brian Inglis via Cygwin-apps wrote:
>> On 2023-01-21 16:57, Brian Inglis via Cygwin-apps wrote:
>>> $ ssh cygwin untest dash-0.5.12-1
>>> Traceback (most recent call last):
>>>    File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
>>>      "__main__", mod_spec)
>>>    File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
>>>      exec(code, run_globals)
>>>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 83, in <module>
>>>      sys.exit(main())
>>>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 79, in main
>>>      untest(p)
>>>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 39, in untest
>>>      if not tool_util.permitted(p):
>>>    File "/sourceware/cygwin-staging/calm/calm/tool_util.py", line 50, in 
>>> permitted
>>>      mlist = maintainers.add_packages(mlist, common_constants.PKGMAINT, 
>>> trustedMaint=common_constants.TRUSTEDMAINT)
>>> TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'
> 
> Thanks for reporting this.
> 
> [...]
>> Newer version not pushed, built, or installed on site?
> 
> No, just a bug I introduced.  I've had a go at fixing it, please try again now.

Thanks Jon,

Now no connection, with same session, ssh-agent, key:

$ ssh cygwin untest dash-0.5.12-1
kex_exchange_identification: Connection closed by remote host
Connection closed by 8.43.85.97 port 22

-- 
Take care. Thanks, Brian Inglis			Calgary, Alberta, Canada

La perfection est atteinte			Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter	not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer	but when there is no more to cut
			-- Antoine de Saint-Exupéry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: untest failing with TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'
  2023-01-22 18:46     ` Brian Inglis
@ 2023-01-22 22:01       ` Brian Inglis
  0 siblings, 0 replies; 5+ messages in thread
From: Brian Inglis @ 2023-01-22 22:01 UTC (permalink / raw)
  To: cygwin-apps; +Cc: Jon Turney

On 2023-01-22 11:46, Brian Inglis via Cygwin-apps wrote:
> On 2023-01-22 03:59, Jon Turney wrote:
>> On 22/01/2023 06:34, Brian Inglis via Cygwin-apps wrote:
>>> On 2023-01-21 16:57, Brian Inglis via Cygwin-apps wrote:
>>>> $ ssh cygwin untest dash-0.5.12-1
>>>> Traceback (most recent call last):
>>>>    File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
>>>>      "__main__", mod_spec)
>>>>    File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
>>>>      exec(code, run_globals)
>>>>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 83, in <module>
>>>>      sys.exit(main())
>>>>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 79, in main
>>>>      untest(p)
>>>>    File "/sourceware/cygwin-staging/calm/calm/untest.py", line 39, in untest
>>>>      if not tool_util.permitted(p):
>>>>    File "/sourceware/cygwin-staging/calm/calm/tool_util.py", line 50, in 
>>>> permitted
>>>>      mlist = maintainers.add_packages(mlist, common_constants.PKGMAINT, 
>>>> trustedMaint=common_constants.TRUSTEDMAINT)
>>>> TypeError: add_packages() got an unexpected keyword argument 'trustedMaint'

>> Thanks for reporting this.

>>> Newer version not pushed, built, or installed on site?

>> No, just a bug I introduced. I've had a go at fixing it, please try again now.

> Now no connection, with same session, ssh-agent, key:
> $ ssh cygwin untest dash-0.5.12-1
> kex_exchange_identification: Connection closed by remote host
> Connection closed by 8.43.85.97 port 22

Retried and now working okay:

$ ssh cygwin untest dash-0.5.12-1
untest: Removed test: label from x86_64/release/dash/dash-0.5.12-1-src.hint
untest: Removed test: label from x86_64/release/dash/dash-0.5.12-1.hint
untest: Removed test: label from 
x86_64/release/dash/dash-debuginfo/dash-debuginfo-0.5.12-1.hint
untest: 3 out of 3 hints for 'dash' version '0.5.12-1' modified

-- 
Take care. Thanks, Brian Inglis			Calgary, Alberta, Canada

La perfection est atteinte			Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter	not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer	but when there is no more to cut
			-- Antoine de Saint-Exupéry

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-01-22 22:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-21 23:57 untest failing with TypeError: add_packages() got an unexpected keyword argument 'trustedMaint' Brian Inglis
2023-01-22  6:34 ` Brian Inglis
2023-01-22 10:59   ` Jon Turney
2023-01-22 18:46     ` Brian Inglis
2023-01-22 22:01       ` Brian Inglis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).